Repository navigation
Conversation
aviralni
force-pushed
the
pyzes_ras_support
branch
2 times, most recently
from
September 23, 2026 10:44
33454bd to
0c00b59
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Default destructive counter clearing, invalid threshold wrapping, and masked test failures must be addressed.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds RAS support to the Sysman Python binding.
Changes:
- Adds RAS types, structures, constants, and seven API wrappers.
- Adds unit and black-box test coverage.
- Documents the new APIs.
| File | Description |
|---|---|
bindings/sysman/python/source/pyzes.py |
Implements RAS bindings. |
bindings/sysman/python/test/unit_tests/test_ras.py |
Tests RAS wrappers. |
bindings/sysman/python/source/examples/pyzes_black_box_test.py |
Adds RAS hardware tests and CLI options. |
bindings/sysman/python/README.md |
Documents supported RAS APIs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Can the self review tool be used here? |
Added following RAS APIs to python binding: 1. zesDeviceEnumRasErrorSets 2. zesRasGetProperties 3. zesRasGetSupportedCategoriesExp 4. zesRasGetStateExp2 5. zesRasGetConfigExp 6. zesRasSetConfigExp 7. zesRasClearStateExp Along with the required handle, enums, structure types and structures (zes_ras_properties_t, zes_ras_state_exp2_t, zes_ras_config_exp_t), unit tests, a RAS section in the black box test and README updates. Related-To: SYSM-429 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
…x test The threshold field is a c_uint64, and ctypes silently wraps values above 2^64 - 1 (2^64 becomes 0, which disables event generation). Related-To: SYSM-429 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
aviralni
force-pushed
the
pyzes_ras_support
branch
from
October 8, 2026 07:13
c87da63 to
2cab0f8
Compare
The RAS tests ran with -r/--ras, but in zello_sysman -r is the device reset and the RAS experimental API test is -re/--rasexp. Use -re/--rasexp so both tools take the same options. --set-threshold and --clear-ras-state are unchanged. Related-To: SYSM-429 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
Added following RAS APIs to python binding: 1. zesDeviceEnumRasErrorSets 2. zesRasGetProperties 3. zesRasGetSupportedCategoriesExp 4. zesRasGetStateExp2 5. zesRasGetConfigExp 6. zesRasSetConfigExp 7. zesRasClearStateExp Along with the required handle, enums, structure types and structures (zes_ras_properties_t, zes_ras_state_exp2_t, zes_ras_config_exp_t), unit tests, a RAS section in the black box test and README updates. Related-To: SYSM-429 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
joshuaranjan
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: Add RAS module support to L0 Sysman python binding
Added following RAS APIs to python binding:
Related-To: SYSM-429
Signed-off-by: Aviral Nigam aviral.nigam@intel.com