CORS origin configuration can break sockets#288
Merged
Conversation
|
@Aditya8369 is attempting to deploy a commit to the omkarhole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed potential socket connection failures caused by brittle Socket.IO CORS origin matching.
Updated backend/server.js:
Added parseOriginsEnv() to robustly parse FRONTEND_URL / FRONTEND_URLS (handles empty/malformed values; trims; removes trailing slashes; filters invalid entries).
Kept HTTP CORS using the normalized origin list.
Changed Socket.IO cors.origin from a static list to a normalization-aware function matcher, so slight origin formatting differences no longer break socket connections.
Made allowed-origin logging development-only (NODE_ENV === 'development').
Verification:
Ran npm test in backend/ successfully (12 tests passed).
Progress tracked:
Modified backend\server.js
closes #253