Skip to content

fix: fix broken links on the first page + bump bikeshed and Python version on RTD#534

Open
lubianat wants to merge 5 commits into
ome:mainfrom
lubianat:fix-internal-links
Open

fix: fix broken links on the first page + bump bikeshed and Python version on RTD#534
lubianat wants to merge 5 commits into
ome:mainfrom
lubianat:fix-internal-links

Conversation

@lubianat

@lubianat lubianat commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

closes #533

Thanks for the catch @elichad

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Automated Review URLs

@jo-mueller

jo-mueller commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@lubianat somehow the build is failing 🤔

@lubianat

lubianat commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@jo-mueller for some reason all the last builds on RTD are failing

grafik

@lubianat

lubianat commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author 
 == Generated coordinate_transformations.html in 0:00:00.219707 == 

(...) 

<html><body>
<!--StartFragment-->
 
--
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/ngff/envs/534/lib/python3.10/site-packages/sphinx/config.py", line 529, in eval_config_file
exec(code, namespace)  # NoQA: S102
File "/home/docs/checkouts/readthedocs.org/user_builds/ngff/checkouts/534/conf.py", line 134, in <module>
build_served_html()
File "/home/docs/checkouts/readthedocs.org/user_builds/ngff/checkouts/534/conf.py", line 119, in build_served_html
subprocess.check_call([sys.executable, script])
File "/home/docs/.asdf/installs/python/3.10.19/lib/python3.10/subprocess.py", line 369, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/home/docs/checkouts/readthedocs.org/user_builds/ngff/envs/534/bin/python', 'specifications/0.2/pre_build.py']' returned non-zero exit status 1.

<!--EndFragment-->
</body>
</html>

@jo-mueller it seems like it is something over there on ngff-spec that for some reason started breaking RTD

@lubianat

lubianat commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

https://pypi.org/project/bikeshed/ had updates including a major
https://pypi.org/project/bikeshed/7.1.0/

it is weird because https://github.com/ome/ngff/blob/main/requirements.txt pins bikeshed<4.2 so that is not the issue

@jo-mueller

jo-mueller commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Maybe bikeshed alao needs to be pinned on the branches from which the 01./0.2/0.3/... Spec pages are built?

@lubianat

lubianat commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I thought that could be the case, but 'bikeshed' is not mentioned in any code in the 0.2 branch (the one failing)

I will dig a bit more. Probably worth it reporting/documenting in a standalone issue. I'll do it.

@lubianat lubianat mentioned this pull request Jun 11, 2026
Closed
@lubianat

lubianat commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@jo-mueller build passing... not sure which side effects this would bring

@lubianat lubianat changed the title fix: fix broken links on the first page fix: fix broken links on the first page + bump bikeshed and Python version on RTD Jun 11, 2026
@lubianat

lubianat commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

last commit changes conf.py, I think that is why the build is not triggered.

It re-adds 2 templates that were lost with the transition; they remove the W3C branding from bikeshed and re-add the OME one

I'll remove it and add it in yet another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

some internal links not working

2 participants

@lubianat @jo-mueller