Repository navigation
Fix panic on reversed slice bounds - #48
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
JsonPathLookup([]int{1, 2, 3, 4, 5}, "$[3:1]")currently panics inreflect.Value.Slice. Negative bounds and ends clamped below zero can trigger the same panic.Clamp the start to the normalized end when the bounds are reversed. The result is an empty slice with its original type. This follows the convention already used by
set_range.The tests cover direct and compiled lookups on integer, interface and named slices. Two existing tests now exercise the reversed bounds they previously avoided.
go test -race -v -coverprofile=coverage.out -covermode=atomic ./...passes on Go 1.15 and 1.23.4, with 91.6% coverage.go build ./...andgo vet ./...also pass. Thirty of the 36 new cases panic before the fix.