feat(http): write headers to disk#3157
Merged
Merged
Conversation
the drawback being that now we get sensitive data on file... 2 things I noticed while reading this quickly:
|
Owner
Author
It was always on file anyway, in the log. The difference is now it's in a temporary location so will be cleaned out by nvim on exit. Or, via the cleanup function at the end of the request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Something that has been on my todo list for far too long...prevent users from accidentally copying API keys when they share their logs.
This PR writes headers to a temp file and then shares the path to the file with
curl.AI Usage
Sonnet 4.6
Related Issue(s)
Screenshots
Checklist
make allto ensure docs are generated, tests pass and StyLua has formatted the code