Skip to content

Bugfix: Fixed support for Beurer BF450 scale#1399

Open
VulcanoHex wants to merge 3 commits into
oliexdev:masterfrom
VulcanoHex:master
Open

Bugfix: Fixed support for Beurer BF450 scale#1399
VulcanoHex wants to merge 3 commits into
oliexdev:masterfrom
VulcanoHex:master

Conversation

@VulcanoHex

Copy link
Copy Markdown
Contributor

The merge request i made yesterday was buggy, since i just added the support to an existing handler, that would only take the first measurement for the user. That was a issue in testing on my part.

So i made a custom handler for the Beurer BF450, updated the scale factory and removed the changes in the previous commit.
The custom BF450Handler currently supports:

  • Creating a user (i couldn't get the sync to an existing user in the scale to work)
  • Adding measurement while connected
  • Syncing with the scale on connection

Still sorry for the previous commit, have a nice day.

when (val s = data[0].toInt() and 0xFF) {
0x00 -> logD("FFF4: misura in corso…")
0x01 -> logD("FFF4: misura completata")
else -> logD("FFF4: status sconosciuto 0x${s.toString(16)}")

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please translate that into English

if (pendingBodyComposition) {
transformed.fat = lastFatPct
transformed.muscle = lastMusclePct
transformed.water = lastBodyWater

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastBodyWater in kg would overwrite the transformed water in % here

val impl = setOf(
DeviceCapability.BODY_COMPOSITION,
DeviceCapability.LIVE_WEIGHT_STREAM,
DeviceCapability.HISTORY_READ,

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the history read really implemented in this handler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants