Conversation
|
API preview: https://pr-35910-api.vm6.ai |
Code Review: PR #35910Reviewed head: SummaryAdds a typed direct/SSH route to saved VNC connections, an independent X.509 server identity, same-owner restrictive SSH references, and current-Runner fail-closed handling before KMS. Generated migrations, production owner/Runner route coverage, and rollout documentation cover the new persisted boundary. FindingsNo findings. TestingFocused contract/database/API lint and type checks passed. The three affected API route files passed together (39 tests), VNC migration replay and full migration/schema consistency passed, generated Rust bindings remained stable, and the online runtime API schema comparison reported zero findings. Repository-wide Vitest was not run per repository guidance; PR CI remains the broader verification boundary. VerdictLGTM |
13b1b6f to
ae3c070
Compare
Summary
Explicit exclusions
Validation
pnpm -F @okouai/api-contracts check-typespnpm -F @okouai/db check-typespnpm -F api check-types:gateways && pnpm -F api check-types:core && pnpm -F api check-types:testspnpm -F @okouai/api-contracts lintpnpm -F @okouai/db lintpnpm -F @okouai/api-contracts generate:rustruntime-api-schema-prod(0 findings)DATABASE_URL=... pnpm -F api exec vitest run src/signals/routes/__tests__/vnc-configuration.test.ts src/signals/routes/__tests__/ssh-connections.test.ts src/signals/routes/__tests__/runner-vnc.test.ts(39 tests)DATABASE_URL=... pnpm -F @okouai/db test:vnc-configurationDATABASE_URL=... pnpm -F @okouai/db exec tsx scripts/test-migration-consistency-schema.tsCloses #35891
Parent context: #35043