Repository navigation
fix(claw): address channel approval review follow-ups - #70
Closed
fabicarvano wants to merge 1 commit into
Closed
fabicarvano wants to merge 1 commit into
fabicarvano wants to merge 1 commit into
Conversation
fabicarvano
marked this pull request as ready for review
October 20, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the six non-blocking recommendations in the maintainer's approved review of PR #65.
AuditService, including tenant, channel, actor, action, and denial reason.approvedByfield withactorIdin new gateway job payloads. Already-queued jobs usingapprovedByremain supported.approval_decision.contentstable and record the acting user in structured event metadata instead.approverIdsin the Mission Control connector settings and API, with input validation, persistence, and explicit allowlist clearing.Type of Change
Testing
bun install --frozen-lockfile— passed.libs/claw-studio,apps/mission-control, andapps/workers.git diff --check— passed.Compatibility and Scope
approve/rejectactions retain backward-compatible behavior if no allowlist is configured. Standing grants viaapprove_alwayscontinue to require an explicit nonempty allowlist.approvedByare accepted during the transition toactorId.Checklist
Refs #65.