Skip to content

fix(claw): address channel approval review follow-ups - #70

Closed
fabicarvano wants to merge 1 commit into
offloadmemory:mainfrom
fabicarvano:fix/pr65-review-followups
Closed

fabicarvano wants to merge 1 commit into
offloadmemory:mainfrom
fabicarvano:fix/pr65-review-followups

Conversation

@fabicarvano

@fabicarvano fabicarvano commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to the six non-blocking recommendations in the maintainer's approved review of PR #65.

  • Return private, generic feedback when a channel approval is denied: ephemeral Slack responses, Telegram callback-query alerts, and ephemeral Discord interaction responses.
  • Record denied approval attempts through AuditService, including tenant, channel, actor, action, and denial reason.
  • Replace the ambiguous approvedBy field with actorId in new gateway job payloads. Already-queued jobs using approvedBy remain supported.
  • Keep approval_decision.content stable and record the acting user in structured event metadata instead.
  • Expose per-channel approverIds in the Mission Control connector settings and API, with input validation, persistence, and explicit allowlist clearing.
  • Add regression tests for missing platform user IDs, authorization denials, private responses, audit entries, and decision attribution.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking configuration support)
  • Breaking change
  • Documentation update
  • Refactor / performance improvement
  • Dependency update
  • CI/CD or build system change

Testing

  • 140 targeted tests passed across five suites covering gateway authorization, run execution, connector configuration, and Slack/Telegram/Discord adapters.
  • bun install --frozen-lockfile — passed.
  • TypeScript checks — passed for libs/claw-studio, apps/mission-control, and apps/workers.
  • git diff --check — passed.
  • GitHub Actions: PR #70 CI run (see live status).
  • Not run: end-to-end interactions with real Slack, Telegram, or Discord accounts. These should be verified in an integration environment before production rollout.

Compatibility and Scope

Checklist

  • Changes follow existing project conventions
  • Relevant tests have been added or updated
  • Local targeted tests and TypeScript checks pass
  • Documentation updated
  • Real-channel integration testing completed
  • GitHub CI confirmed successful

Refs #65.

@fabicarvano fabicarvano changed the title fix(claw): complementar segurança e auditoria das aprovações (#65) fix(claw): address channel approval review follow-ups Oct 20, 2026
@fabicarvano
fabicarvano marked this pull request as ready for review October 20, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant