Fix/contributing guide#336
Merged
observingClouds merged 12 commits intoMar 12, 2026
Merged
Conversation
observingClouds
requested changes
Mar 6, 2026
observingClouds
left a comment
observingClouds
left a comment
Owner
There was a problem hiding this comment.
Thanks for catching this and opening a PR. I made a few minor suggestions.
Please also add an entry to the CHANGELOG and then we should be good to go 😃
Co-authored-by: Hauke Schulz <43613877+observingClouds@users.noreply.github.com>
Co-authored-by: Hauke Schulz <43613877+observingClouds@users.noreply.github.com>
Co-authored-by: Hauke Schulz <43613877+observingClouds@users.noreply.github.com>
see uvx usage of observingClouds@41153b2 Co-authored-by: Hauke Schulz <43613877+observingClouds@users.noreply.github.com>
Not needed with the current setup of AUTHORS.rst
Contributor
Author
|
Thanks for the suggestions @observingClouds ! I accepted all of them. Added the info to CHANGELOG.rst, so let me know if you think it is ready to merge. |
Contributor
Author
|
Tests are failing, but not related to my PR as far as I can see? |
Owner
|
This is indeed unrelated. This is an issue with |
observingClouds
approved these changes
Mar 12, 2026
observingClouds
left a comment
observingClouds
left a comment
Owner
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking out the contributing guide, I noticed that it sill uses conda, while the project seems to have moved to uv (e.g. in the CI).
Therefore these minor proposed changes to work with uv instead of conda.
Also added pre-commit and asv as test dependencies