Skip to content

fix(tests): resolve shellcheck warnings in Claude Code test helpers #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
creazyfrog wants to merge 1 commit into
base: dev
Choose a base branch
from
+17 −7
Open

fix(tests): resolve shellcheck warnings in Claude Code test helpers #1826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/claude-code/test-helpers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ run_claude() {
local prompt="$1"
local timeout="${2:-60}"
local allowed_tools="${3:-}"
local output_file=$(mktemp)
local output_file
output_file=$(mktemp)

# Build command as an argv array so timeout wraps claude directly.
local cmd=(claude -p "$prompt")
Expand Down Expand Up @@ -74,7 +75,8 @@ assert_count() {
local expected="$3"
local test_name="${4:-test}"

local actual=$(echo "$output" | grep -c "$pattern" || echo "0")
local actual
actual=$(echo "$output" | grep -c "$pattern" || echo "0")

if [ "$actual" -eq "$expected" ]; then
echo " [PASS] $test_name (found $actual instances)"
Expand All @@ -98,8 +100,9 @@ assert_order() {
local test_name="${4:-test}"

# Get line numbers where patterns appear
local line_a=$(echo "$output" | grep -n "$pattern_a" | head -1 | cut -d: -f1)
local line_b=$(echo "$output" | grep -n "$pattern_b" | head -1 | cut -d: -f1)
local line_a line_b
line_a=$(echo "$output" | grep -n "$pattern_a" | head -1 | cut -d: -f1)
line_b=$(echo "$output" | grep -n "$pattern_b" | head -1 | cut -d: -f1)

if [ -z "$line_a" ]; then
echo " [FAIL] $test_name: pattern A not found: $pattern_a"
Expand All @@ -125,7 +128,8 @@ assert_order() {
# Create a temporary test project directory
# Usage: test_project=$(create_test_project)
create_test_project() {
local test_dir=$(mktemp -d)
local test_dir
test_dir=$(mktemp -d)
echo "$test_dir"
}

Expand Down
6 changes: 4 additions & 2 deletions tests/claude-code/test-subagent-driven-development-integration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ TEST_PROJECT=$(create_test_project)
echo "Test project: $TEST_PROJECT"

# Trap to cleanup
trap "cleanup_test_project $TEST_PROJECT" EXIT
_cleanup() { cleanup_test_project "$TEST_PROJECT"; }
trap _cleanup EXIT

# Set up minimal Node.js project
cd "$TEST_PROJECT"
Expand Down Expand Up @@ -165,9 +166,10 @@ PLUGIN_DIR=$(cd "$SCRIPT_DIR/../.." && pwd)
echo "Running Claude (plugin-dir: $PLUGIN_DIR, cwd: $TEST_PROJECT)..."
echo "================================================================================"
cd "$TEST_PROJECT" && timeout 1800 claude -p "$PROMPT" --plugin-dir "$PLUGIN_DIR" --allowed-tools=all --permission-mode bypassPermissions 2>&1 | tee "$OUTPUT_FILE" || {
exit_code=$?
echo ""
echo "================================================================================"
echo "EXECUTION FAILED (exit code: $?)"
echo "EXECUTION FAILED (exit code: $exit_code)"
exit 1
}
echo "================================================================================"
Expand Down
4 changes: 4 additions & 0 deletions tests/claude-code/test-worktree-path-policy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,19 @@ assert_not_contains() {
echo "=== Worktree Path Policy Test ==="
echo ""

# shellcheck disable=SC2088 # Tilde is intentional: checking for the literal string "~/.config/..." in skill file text
assert_not_contains "$USING_SKILL" "~/.config/superpowers/worktrees" "using-git-worktrees does not mention old global path"
assert_not_contains "$USING_SKILL" "global legacy" "using-git-worktrees does not use unclear global legacy shorthand"
assert_not_contains "$USING_SKILL" "Global path" "using-git-worktrees has no global path quick-reference row"
assert_contains "$USING_SKILL" 'default to `.worktrees/` at the project root' "using-git-worktrees defaults new manual worktrees to .worktrees/"

# shellcheck disable=SC2088 # Tilde is intentional: checking for the literal string "~/.config/..." in skill file text
assert_not_contains "$FINISHING_SKILL" "~/.config/superpowers/worktrees" "finishing-a-development-branch does not treat old global path as owned"
assert_contains "$FINISHING_SKILL" '`.worktrees/` or `worktrees/`' "finishing-a-development-branch keeps project-local cleanup ownership"

# shellcheck disable=SC2088 # Tilde is intentional: checking for the literal string "~/.config/..." in skill file text
assert_not_contains "$ROTOTILL_SPEC" "~/.config/superpowers/worktrees" "rototill spec does not preserve old global path policy"
# shellcheck disable=SC2088 # Tilde is intentional: checking for the literal string "~/.config/..." in skill file text
assert_not_contains "$ROTOTILL_PLAN" "~/.config/superpowers/worktrees" "rototill plan does not preserve old global path policy"
assert_not_contains "$ROTOTILL_PLAN" "legacy path compat" "rototill plan does not advertise legacy path compatibility"

Expand Down