Skip to content

fix(sdd): add -C DIR flag to review-package for harness allowlisting #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
citizen204 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

fix(sdd): add -C DIR flag to review-package for harness allowlisting #1809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions skills/subagent-driven-development/scripts/review-package
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,23 @@
# call. Using the recorded per-task BASE (not HEAD~1) keeps multi-commit
# tasks intact.
#
# Usage: review-package BASE HEAD [OUTFILE]
# Usage: review-package [-C DIR] BASE HEAD [OUTFILE]
# Default OUTFILE: <repo-root>/.superpowers/sdd/review-<base7>..<head7>.diff
# (named per range, so a re-review after fixes gets a distinct fresh file).
set -euo pipefail

# Optional leading "-C DIR": run as if invoked from DIR, so callers whose
# cwd isn't the repo don't need a `cd DIR ; review-package ...` compound.
# (That compound can't be allowlisted by harnesses because BASE and the
# worktree path vary on every run.)
if [ "${1:-}" = "-C" ]; then
[ -d "${2:-}" ] || { echo "bad -C dir: ${2:-}" >&2; exit 2; }
cd "$2"
shift 2
fi

if [ $# -lt 2 ] || [ $# -gt 3 ]; then
echo "usage: review-package BASE HEAD [OUTFILE]" >&2
echo "usage: review-package [-C DIR] BASE HEAD [OUTFILE]" >&2
exit 2
fi

Expand Down