Fix dropped events when run streams finish during subscription - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A fast run can finish after a client subscribes but before it finishes replaying events. The Go SDK then rereads the terminal status and exits without draining its live channel, dropping queued text and tool results. This caused
TestStreamOrderAndWaitto fail in the v0.1.39 release gate: https://github.com/oblien/mindwire/actions/runs/37165823800/job/111328736927.Share the supervisor's subscription lifecycle between the Go SDK and HTTP SSE endpoint. Subscribers drain until the producer closes the stream, including events published after the terminal record is saved. Completed runs whose buffers expired or disappeared after a restart close without creating an orphaned live topic.
Component
mindwire(TypeScript)Type of change
Validation
go test -race ./... -skip '^TestLiveClaude$' -timeout 5mpassed. Only the host-authenticated external Claude test was excluded locally; CI runs the normal suite.gofmt,go vet ./...,go build ./..., andgovulncheckpassed.Checklist