Repository navigation
pm(contract-review): name ④'s rules face as the governed register, scenario per surface - #26651
Merged
Merged
Conversation
…enario per surface The --template ④ note read the rules face as three surfaces (published spec, skills, ADRs); it now names the published spec and the governed register, which holds the skills and ADR surfaces among its rows. The note and the reviewer brief name the accepted scenario per surface: a skill file against the card's eval prompt and the spec it teaches, a schema file against the ruling or ADR it implements and its first consumer, an ADR against its first consumer and its execution plan. One new self-test pin each; battery floors 27 -> 28 and 16 -> 17. Claude-Session: https://claude.ai/code/session_01ADHkmSpW72m8tVh1b1rPxQ Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
席位核对ACCEPT ·
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Steve · project thread
Part of #26527 (items 1 and 2; item 3, design judgment on the narrowing face, stays open for the maintainer's word and goes to the decision box after this PR)
Clause-②: no
Metadata-protocol: none
维护者速读
scripts/pm/record-recognisers.mjs打印的提示文字和它的自测,不碰任何读取逻辑;回滚即 revert 这一个提交。scripts/pm/record-recognisers.mjs的--template④ 说明段和contractReviewBriefLines的 ④ 段,再看两条新 pin。node scripts/pm/record-recognisers.mjs --brief-template --face rules,④ 段应出现 skill / schema / ADR 三句场景。What changes
--template④ note (contractReviewTemplateLines): the rules face now reads as "the published spec, and the governed register, which holds the skills and ADR surfaces the full-review order names among its rows" instead of "the published spec, skills and ADR surfaces". The governed register does not holdpackages/spec(that is the schema face), so the card's suggested sentence was taken in the equivalent form the card allows, keeping the two faces apart.contractReviewBriefLines) now name the accepted scenario per surface: a skill file against the card's eval prompt and the spec it teaches onmain; a schema file against the ruling or ADR it implements and its first consumer; an ADR against its first consumer and its execution plan..claude/skills/pm-dispatch/references/contract-review.mdis NOT touched: its ④ line (L30) already names the schema and governed-rules-text faces with spec, skills and ADRs inside them, so it does not say "three surfaces". The diff touches no governed path.Tests
node scripts/pm/record-recognisers.mjs --self-test: 217 cases pass, exit 0, at84e6125b.Acceptance notes
AGENTS.md,.github/workflows/**,.claude/agents/**, hooks) keep only the generic "the scenario it is accepted against"; the card names scenarios for skill, schema and ADR files only.Verification
All at head
84e6125b(after the last commit), in this worktree.dispatch-gates --commands: 31 derived, 31 run, 0 NOT-MEASURED, 0 UNRUN (DERIVED zero)
pnpm check:pm-skill-ratchetis outside this diff's derivation (no.claude/**path) and was run because the card's acceptance names it.pnpm check:pm-dispatch-gates: fast tier, 1935 cases pass, 479.4 s.CI families (lint, type check, tests) are the PR's check-runs; not re-run locally.
Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintpasses. (no formatter ran;pnpm lintis CI's run, see check-runs)main, one pull request.scripts/pm/**only,skip-changeset)packages/spectouched: its generated artifacts are regenerated and committed. (not touched)content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.Generated by Claude Code