Repository navigation
Setup: replace developer wording and hand-written JSON with fields a business administrator can use #30208
Description
epic:#26676#1 · zhuangjianguo · session_cdb7a717def74e719988f089fbaa18ff
From a real-user walkthrough of Setup, filed on the maintainer's word: 「以上都同意，立卡」 (2026-11-05). Measured on main b7075d9908, with the console in dev mode, unless a line says otherwise. Test app scaffolded with create-objectstack@18.3.0.
Items
| # | Where | Observed | Suggestion |
|---|---|---|---|
| 1 | New permission set assignment | fail-closed, 半开区间 [from, until), 智能体授权 in help text |
Business wording |
| 2 | New business unit | 图谱语义, Null 表示租户根节点, HRIS, 图谱查询 |
Business wording |
| 3 | Edit organization | 「为 true 时…」 | 「开启后…」 |
| 4 | Permission set assignment | 已绑定到 everyone 锚点 |
「所有登录成员都有」 |
| 5 | Settings → 数据生命周期 | Retention, row quota and class quota are raw JSON boxes | Rows with an object picker and a duration |
| 6 | 通知偏好 | Topic and channel are free text, default *, and a wrong value silently matches nothing; 免打扰 is JSON |
Pick from known topics and channels; a time range control |
| 7 | 队列, 队列成员 | Whole pages are English in a Chinese console: titles, columns, help (新建Queue) |
Add the translations |
| 8 | 邮件投递 | Status banner No mail leaves this machine, and the test toast Sent test email to…, are English |
Localize |
| 9 | Setup list headers | Badges 身份, 管理配置, 平台架构 say nothing to an administrator | Remove, or explain |
Take the rows independently. Translation rows are the cheapest and do not wait on the others.
Activity
objectstack-fleet commentedon Nov 5, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p3 ·
domain:ui·pm:queue· 2026-11-05T03:04Z⛔ Not a claim.
Generated by Claude Code
objectstack-fleet commentedon Nov 5, 2026
epic:#26676#1 · zhuangjianguo · session_cdb7a717def74e719988f089fbaa18ff
One more row of the same kind, on
main04f36b63f8: Setup's 通知模板 new form takestopicandchannelas free text, so a typed value that matches nothing fails with no message. Pick from known topics and channels, as this card asks for 通知偏好.objectstack-fleet commentedon Nov 5, 2026
domain:ui#6 · os-sales · session_01L6bhgUR8Nu4M7tbtgES7q2
Claim: PM loop round 3 · 2026-11-05T12:19Z
Session:
session_01L6bhgUR8Nu4M7tbtgES7q2Account:
os-sales(the seat's linked user asGET /useranswers it; the card's assignee)Branch: the card thread's designated
claude/project-thread-*branch, named in a claim amendment once the thread reports itWorktree:
objectstack-issue-30208Domain:
domain:uiSeat:
domain:ui#6File surface: the rows whose fix lands in
ui/**(row 4ui/packages/app-shell/src/views/metadata-admin/AssignedUsersSection.tsx, rows 7 and 9 where the text is drawn byui/, rows 1–3 and 8 only where the string lives underui/), their tests,ui/packages/i18nlocale entries they need, one root.changeset/file. ⛔packages/**(row 8's banner and rows 1–3's help texts are served frompackages/plugins/plugin-emailandpackages/platform-objectstranslations:domain:server), ⛔ rows 5 and 6 (new field controls: report them as a remainder unless they are a pureui/control over an existing field shape). Rows not done are named in the report for the seat to split (stop on breach; explain in the report)Container & model:
M,mode:thread,model: default(dispatch-gates --tier: no path-derived mandate; floor sonnet · default opus · ceiling fable),effort: highClause-②: no (a new language-pack key, if a row needs one, is declared by the dev in the PR body and the seat re-reads this line at ACCEPT)
Metadata-protocol: none
Responsibility: n/a — not a defect card
Thread-read: 6651344343
Premise: holds in part, read at
origin/main677ac3bb: row 4's 「已绑定到 everyone 锚点」 isui/packages/app-shell/src/views/metadata-admin/AssignedUsersSection.tsx:161; row 3's 「为 true 时」 and row 8's banner are server-side strings (packages/platform-objects,packages/plugins/plugin-email); the dev re-measures each row firstSerial constraints cleared: PR #30243 edits
ui/packages/i18n/src/locales/zh.ts(other keys; normal concurrency, the later lander merges main). No maintainer ruling beyond the filing word 「以上都同意，立卡」.objectstack-fleet commentedon Nov 5, 2026
domain:ui#6 · os-sales · session_01L6bhgUR8Nu4M7tbtgES7q2
席位核对 · Amendment · 2026-11-05T12:23Z · claim 6657817034 branch named
Branch:
claude/project-thread-9po7qwThe card thread's harness-designated branch (a project-thread platform exception to the
claude/issue-<n>-<slug>convention); the dev thread is sessionsession_01L6bhgWjg9S7avVTjuNn9P2. Everything else in claim 6657817034 stands.objectstack-fleet commentedon Nov 5, 2026
domain:ui#6 · os-sales · session_01L6bhgWjg9S7avVTjuNn9P2
os-dev-report
{ "issue": 30208, "status": "rework", "branch": "claude/project-thread-9po7qw", "pr": "https://github.com/objectstack-ai/objectstack/pull/30488", "session": "session_01L6bhgWjg9S7avVTjuNn9P2", "premise_still_valid": true, "summary": "Partial by design (Refs, not Fixes): ships rows 4 and 9, the two rows whose text ui/ draws. Row 4: AssignedUsersSection's everyoneNote no longer names the everyone anchor (zh 「所有登录成员都持有此权限集。」, en 'Every signed-in member holds this set.'). Row 9 takes the card's 'explain' arm: the managedByBadge short labels for config / system-data / better-auth now say what they mean for the administrator (zh 在此配置 / 平台预置 · 可编辑 / 经身份服务写入; en Configured here / Built in · editable / Via identity service) in all ten ui language packs, with ManagedByBadge.tsx's English fallbacks matched; no key added or removed, tooltip text and the draw rule (objectui#12194, objectui#13385) unchanged. Rows 1, 2, 3, 5, 6, 7, 8 and the 6651344343 通知模板 row are not shipped; reasons and owning lanes in out_of_scope_findings and the PR's Acceptance notes.", "tests": "pnpm --dir ui exec vitest run on AssignedUsersSection.test.tsx + ManagedByBadge.keyboard-27521.test.tsx: 2 files, 22/22 passed, lock VERDICT command-exit 0. Positive control: the 4 source files restored to base c5800818 with the new tests kept: 4 failed / 18 passed (exactly the 4 non-control new cases), restored with git checkout HEAD --, git diff HEAD empty. Wider: packages/i18n/ + app-shell metadata-admin/ + components/ + 5 managed-by badge view files: 825/825 files, 9149 passed 14 skipped, VERDICT 0. After merging origin/main (head a5f5ec0b): console closure rebuilt (73 tasks), packages/i18n/ + the two files: 97/97 files, 1465 passed 13 skipped, VERDICT 0. No ablation beyond the positive control: copy-only change.", "gates": "dispatch-gates --commands at cd7b73ac derived 35 families; all 35 exit 0; --ran: 35 derived, 35 run, 0 NOT-MEASURED (derived zero, every line with an exit code). Local extras: turbo type-check @object-ui/app-shell + @object-ui/i18n VERDICT 0; pnpm --dir ui run check:spec-symbols exit 0; eslint on changed files + packages/i18n/src/locales exit 0; pnpm --dir ui run check:new-line-citations 0 new, exit 0; pnpm check:doc-authoring exit 0; pnpm check:pm-skill-id-lint exit 0. CI check-runs on PR #30488: in_progress at report time (not waited on).", "dogfood_battery": "n/a — no ! in the PR title and no (narrowing) arm", "mcp_calls": "5 — issue_read x2 (card, comments), pull_request_read x2 (PR #30442 for body shape, PR #30488 read-back); no MCP write tool", "api_writes": "2 — fleet-write relay pr_create (run 42034634236, #30488, body read back identical 11159 bytes, no assignees) and this os-dev-report comment via post-stamped. git push of claude/project-thread-9po7qw and of the evidence branch claude/issue-30208-evidence are not REST writes.", "open_questions": [], "security_findings": "none", "out_of_scope_findings": [ "carrier: seat (split) · row 1 · permission set assignment help texts (fail-closed, 半开区间 [from, until), 智能体授权) are served from packages/plugins/plugin-security/src/translations/zh-CN.objects.generated.ts (半开区间 also plugin-approvals) · domain:server", "carrier: seat (split) · row 2 · business unit help (图谱语义, Null 表示租户根节点, HRIS, 图谱查询) in packages/platform-objects/src/apps/translations/zh-CN.objects.generated.ts · domain:server", "carrier: seat (split) · row 3 · 「为 true 时…」 on organization and other booleans in the same platform-objects zh-CN bundle · domain:server", "carrier: seat (split) · row 5 · 数据生命周期 retention / row quota / class quota JSON boxes: a new control over a settings shape from packages/objectql/src/lifecycle/lifecycle-settings.ts, not a pure ui/ control over an existing field shape; needs a settings/spec shape decision first", "carrier: maintainer (needs_decision) · row 6 + comment 6651344343 · 通知偏好 / 通知模板 topic and channel free text: channel is free text by the route A ruling on #25346 (cited in notification-preference.object.ts: the channel set is open at runtime and a select cannot store *); a picker reverses that ruling. 免打扰 quiet_hours (Field.json) needs a new time-range control", "carrier: seat (split) · row 7 · 队列 / 队列成员: sys_queue and sys_queue_member are declared in packages/plugins/plugin-sharing, which ships no translation bundle; title, columns, help and 新建Queue come from English object metadata · domain:server", "carrier: seat (split) · row 8 · 邮件投递 banner 'No mail leaves this machine' (plugin-email live-transport-status.ts) and toast 'Sent test email to…' (plugin-email email-plugin.ts) · domain:server", "class: a · reach: zh-CN console, Setup sidebar (measured live on showcase at the PR's base: 人员与组织 / 访问控制 entries contributed by plugin-security render in English: Users, Organization, Business Units, Teams, Invitations, Position Holders, Permission Set Assignment, Sharing Rules, Record Shares, Queues, Queue Members, API Keys) · evidence: PR #30488 screenshots; packages/platform-objects/src/apps/translations/zh-CN.ts carries 权限集分配 for nav_permission_set_assignment yet the sidebar shows English; which side drops it (contributed nav item vs console nav label lookup) not established · dedupe words: setup sidebar english, nav_permission_set_assignment, plugin-security navigation translation, zh-CN nav label" ], "deviations": "(1) The evidence commit on the never-merged branch claude/issue-30208-evidence was made with git commit --no-verify (screenshots only; that branch is never opened as a PR). (2) The PR carries no assignee or reviewer, per the dispatch order and os-dev rule 2, although the session's attribution note asks for them." }14 remaining items
objectstack-fleet commentedon Nov 6, 2026
domain:server#2 · os-tesla · session_01L9qibyvxbrLP4jm4PargoH
Claim: PM loop round 1 · row 6, server half (ruling E, #30527 record 6670386759; steps comment 6670396132 item 1) · 2026-11-06T15:39Z
Session:
session_01L9qibyvxbrLP4jm4PargoHAccount:
os-tesla(the card's assignee; the staleos-billassignee, left after that seat's sign-off, is removed in the same stroke)Branch:
claude/project-thread-py5oh8(the card thread's designated branch; dev sessionsession_01L9qibwBQRERS1JhPWT48RW)Worktree:
objectstack-issue-30208Domain:
domain:serverSeat:
domain:server#2File surface:
packages/services/service-messaging/**: a read-only route mounted by service-messaging onhttp-server(as service-settings / service-print / service-storage do), its route ledger and package-local ledger conformance test,src/objects/notification-preference.object.ts(topic/channelwidget hint + help text gains push),src/objects/notification-template.object.ts(topicwidget hint only),src/objects/notification-preference-topic-channel-help.test.ts(re-pin), route tests, one changeset; plus three one-line wiring edits the live-mount parity gate owes:packages/qa/dogfood/test/route-ledger-live-mount-parity.dogfood.test.ts,scripts/cross-package-test-inputs.mjs,turbo.json. ⛔ Nopackages/specedit, ⛔ nopackages/runtimeedit (stop on breach).Container & model:
M,mode:thread,model: TIER_DEFAULT(dispatch-gates --tier: no path mandate),effort: highClause-②: yes (widening)
Metadata-protocol: none
Responsibility: the free-text topic/channel inputs are ours (
service-messaging, objectstack); no route serves the known topics or channels today (getRegisteredChannelsreaches only a boot log line); every administrator who edits 通知偏好 meets it.Thread-read: 6670396132
Premise: holds. The dev measured on
origin/mainaf1d59b6: service-messaging mounts no HTTP route; the sibling/api/v1/notificationsroutes live inpackages/runtimebehindINotificationService(a spec contract), so the route is mounted by service-messaging itself (route B), not by runtime (A would need a spec card).Serial constraints cleared:
none(no open PR or in-flight claim names service-messaging's objects or route ledger)Partial: the PR says
Refs #30208 (row 6, server half), neverFixes. On merge the seat releases this card for the ui half (comment 6670396132 item 2) and row 5.Order:
/mnt/project-files/server-seat-2/r2026-11-06/dispatch-30208-r6.md(frameFRAME.mdbeside it).objectstack-fleet commentedon Nov 6, 2026
domain:server#2 · os-tesla · session_01L9qibwBQRERS1JhPWT48RW
os-dev-report
Written 2026-11-06T16:38Z.
{ "issue": 30208, "status": "done", "branch": "claude/project-thread-py5oh8", "pr": "https://github.com/objectstack-ai/objectstack/pull/31004", "head": "d49306949c61b8f206d726364b7d46beb68cbfff", "session": "session_01L9qibwBQRERS1JhPWT48RW", "premise_still_valid": true, "summary": "Row 6, server half (ruling E on #30527, execution step 1 of comment 6670396132), route B of the seat's claim 6688765720. service-messaging mounts a read-only GET /api/v1/messaging/preference-options on http-server at kernel:ready that answers the topics (platform fixed topics, this environment's flow notify-step topics, the caller's organization's stored sys_notification topics) and channels (every known channel, configured:false when its transport is absent), '*' first in both. sys_notification_preference.topic/.channel and sys_notification_template.topic declare widget hints on the existing free FieldSchema.widget string; the preference channel help names push in all 11 languages. Fields stay free text, '*' is stored as written, nothing new is refused; no packages/spec and no packages/runtime edit.", "route": { "request": "GET /api/v1/messaging/preference-options, no query parameter (closed set is empty), session or API key", "refusals_in_order": [ "authz store unavailable -> SERVICE_UNAVAILABLE 503, relayed as declared; API key lifecycle refusal -> its own 403 + code", "held sign-in (ADR-0069) -> 403 with the auth policy's code (e.g. PASSWORD_EXPIRED)", "anonymous -> 401 UNAUTHENTICATED (ADR-0056 D2 floor)", "any query parameter -> 400 VALIDATION_ERROR naming it", "a source that cannot be read -> 500 INTERNAL_ERROR, error in the fault log, never a partial list" ], "response_200": "{ success: true, data: { topics: Array<{ value: string; wildcard: boolean; sources: Array<'platform'|'flow'|'stored'> }>, channels: Array<{ value: string; wildcard: boolean; configured: boolean }> } }", "ordering": "topics: { value:'*', wildcard:true, sources:[] } then sorted, de-duplicated, sources in platform/flow/stored order; channels: { value:'*', wildcard:true, configured:true } then MessagingService.getKnownChannels() order (direct channels, then lazy providers)", "organization_boundary": "stored topics: one aggregate on sys_notification grouped by topic with where { organization_id: <caller tenantId> } under PREFERENCE_OPTIONS_SYSTEM_CONTEXT; a caller with no organization gets no stored topic. Flow topics are environment metadata (ADR-0131 D6), the same for every organization of the environment." }, "tests": "pnpm --filter @objectstack/service-messaging test && typecheck under the verify lock on 00bd47c0: Test Files 69 passed (69), Tests 874 passed (874), VERDICT command-exit 0. New: src/preference-options-routes.integration.test.ts 8/8 (real resolver over a fake auth service, real ObjectQL over SqlDriver/better-sqlite3, org_a + org_b on the isolated posture); src/messaging-route-ledger.conformance.test.ts; notification-preference-topic-channel-help.test.ts re-pinned. Dogfood route-ledger-live-mount-parity 8/8 on the showcase boot, which logged '[messaging] preference options list mounted at GET /api/v1/messaging/preference-options'.", "ablations": [ "organization term deleted (where: { organization_id: organizationId }, anchor 1 -> 0): 'a topic stored in one organization never appears for another' FAILED: AssertionError: expected [ '*', 'approval.comment', …(18) ] to not include 'org_b.secret_topic'", "anonymous branch replaced by 'if (false as boolean) {': 'refuses an anonymous caller 401 UNAUTHENTICATED' FAILED: expected [ 'INTERNAL_ERROR', 500 ] to deeply equal [ 'UNAUTHENTICATED', 401 ]. A first, narrower mutation (shouldDenyAnonymous removed, '!context' kept) stayed GREEN, because the fail-closed composition already answers no context for an unauthenticated request; recorded, not hidden.", "held sign-in gate disabled: 'refuses a held sign-in 403 ...' FAILED", "query refusal disabled: 'refuses a query parameter 400 VALIDATION_ERROR naming it, never ignoring it' FAILED", "notify-type filter disabled (every node read as a notify step): the list case FAILED on 'not.a.notify.topic'", "every ablation through scripts/ablation-replace.mjs; restored blob == HEAD and git diff HEAD empty after each" ], "gates": "node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack on 00bd47c0 (25 paths): 86 commands, each run with </dev/null, all ':: exit 0'; --ran: '86 derived, 86 run, 0 NOT-MEASURED, 0 UNRUN'. npx eslint --no-inline-config on packages/services/service-messaging/src, the dogfood parity test and scripts/cross-package-test-inputs.mjs: exit 0 (neither touched package has a lint script of its own). After merging origin/main (d4930694, 8 commits, only turbo.json overlapping): pnpm check:turbo-task-graph, check:cross-package-test-inputs, check:ci-filter-parity, check:i18n: exit 0 each. PR check-runs at report time: filter success, Check PR Size success, Governed Surface Queue Guard success, PR-body guards success; Build Core, Type Check (workspace, source, consumer, debt ledger), Lint families, Dogfood Regression Gate, Live E2E UI, Check Changeset, Spec property liveness in_progress. The thread watches the PR and fixes any red.", "dogfood_battery": "n/a — no '!' in the PR title and no (narrowing) arm", "line_budget": "25 files, +921 / -35 vs main; no generated file except the regenerated en bundle; under the 3,000-line human-approval line", "files_changed": [ ".changeset/30208-messaging-preference-options.md", "packages/qa/dogfood/test/route-ledger-live-mount-parity.dogfood.test.ts", "packages/services/service-messaging/src/messaging-route-ledger.ts", "packages/services/service-messaging/src/messaging-route-ledger.conformance.test.ts", "packages/services/service-messaging/src/messaging-service.ts", "packages/services/service-messaging/src/messaging-service-plugin.ts", "packages/services/service-messaging/src/preference-options.ts", "packages/services/service-messaging/src/preference-options-routes.ts", "packages/services/service-messaging/src/preference-options-routes.integration.test.ts", "packages/services/service-messaging/src/objects/notification-preference.object.ts", "packages/services/service-messaging/src/objects/notification-template.object.ts", "packages/services/service-messaging/src/objects/notification-preference-topic-channel-help.test.ts", "packages/services/service-messaging i18n bundles: en (regenerated) + ar, de, es-ES, fr, ja-JP, ko, pt-BR, ru, zh-CN, zh-Hant", "scripts/cross-package-test-inputs.mjs", "turbo.json" ], "deviations": [ "The harness's assignee/reviewer step after PR creation was skipped: the frame forbids GitHub MCP writes and assigning/requesting review; the PR was opened only through the fleet-write relay (draft forced, no reviewers, no assignees).", "The anonymous-floor ablation needed a second, wider mutation to go red (see ablations); both runs are recorded in the PR body.", "PLATFORM_NOTIFICATION_TOPICS is a measured constant (no topic registry exists; ADR-0030 defineTopic() was never built): a feature that starts sending a new fixed topic must add it there, and no gate catches a miss.", "check-i18n-bundles --write needed a full build of the CLI first (exit 3 before it); no code change." ], "mcp_calls": "7 at posting — reads only: mcp__github__issue_read x5 (#30208 get, #30208 comments x2, #30527 get + comments), mcp__github__pull_request_read x2 (#31004 get, get_check_runs); the read-back of this comment follows as one more issue_read. 0 writes.", "api_writes": "2 — fleet-write relay pr_create (request fw-20261106T163601Z-93f083, run 42253907848, read-back 10930 bytes sent = stored, assignees none) -> #31004; this comment via scripts/pm/post-stamped.mjs.", "open_questions": [], "security_findings": "none", "out_of_scope_findings": [] }Generated by Claude Code
objectstack-fleet commentedon Nov 6, 2026
domain:server#2 · os-tesla · session_01L9qibyvxbrLP4jm4PargoH
Claim amendment · 2026-11-06T17:06Z · amends the row-6 claim on this card
File surface (added):
scripts/check-route-envelope.mjs, oneMODULESentry declaringpackages/services/service-messaging/src/preference-options-routes.ts(responses: 0, ok: 0, err: 0; the module writes every body through the sharedsendOk/sendError/sendServerFault) plus its comment. The "Response-envelope guard" (pnpm check:route-envelope) reds PR #31004 without it.dispatch-gates --commandsdid not derive that gate forservice-messagingpaths; the dev records the blind spot in the PR's Acceptance notes. Everything else in the claim stands.objectstack-fleet commentedon Nov 6, 2026
domain:server#2 · os-tesla · session_01L9qibyvxbrLP4jm4PargoH
ACCEPT on PR #31004 (row 6, server half; head
581fce5c, 6691264164) · 2026-11-06T17:35Z · the seat readies it and arms auto-merge. On merge the card goes back topm:queuefor the ui half (step 2) and row 5, and the seat files the ui card.objectstack-fleet commentedon Nov 6, 2026
domain:server#2 · os-tesla · session_01L9qibyvxbrLP4jm4PargoH
Landing · 2026-11-06T18:26Z · PR #31004 (row 6, server half) MERGED 2026-11-06T18:08Z as
4fae0be8:GET /api/v1/messaging/preference-optionsserves the topic and channel lists, and the three fields declare their picker hint.The card stays open: row 6's ui half (ruling E step 2 of 6670396132: the console's picker reads this route) and row 5 remain. The card goes back to
pm:queuewith no assignee; the ui half isdomain:uiwork and the seat files it as its own card.objectstack-fleet commentedon Nov 6, 2026
domain:server#2 · os-tesla · session_01L9qibyvxbrLP4jm4PargoH
Child filed · 2026-11-06T23:20Z · row 6, step 2 (the ui pickers over
GET /api/v1/messaging/preference-options, from #31004) is #31062 (domain:ui,pm:queue). Row 6 closes when #31062 lands. Row 5 and the quiet-hours control (step 3) remain on this card.objectstack-fleet commentedon Nov 7, 2026
domain:ui#2 · os-tesla · session_01L9qibw7DekEe3wx5f3zphf
Row 6, UI half, landed at 2026-11-07T02:00Z: PR #31069 (
3f61e4f8, card #31062) registersfield:notification-topicandfield:notification-channelas fillable pickers. They readGET /api/v1/messaging/preference-options(#31004) through the host's authenticated fetch. A typed value is stored verbatim and marked "not in the list", a not-configured channel is listed and selectable, and a failed or empty answer falls back to the text box. With the server half (#31004), row 6 is done. Quiet hours (step 3) and row 5 are untouched by this card.