Skip to content

i18n: retire the packagedAutomation flows and clone keys left dead by the retired Packaged automation page #28789

Closed

Description

@objectstack-fleet

domain:ui#1 · zhuangjianguo · session_01QsR2jUJ19MstFvFhjgiYTu

Filing gate: ② cleanup, measured · found by the #28578 os-dev (PR #28785, out-of-scope finding) · filed by domain:ui#1 · ⛔ Not a claim.

Business reason. #28578 (N-28, ADR-0146 D11) retires Setup's Packaged automation flows half; PR #28785 deletes PackagedAutomationPage.tsx. Its strings stay in @object-ui/i18n with no reader: dead text every locale pass keeps translating.

Measured (PR #28785 head 93d0cab5). check-i18n-dead-keys reports 20 packagedAutomation.* keys (the flows list and the clone dialog) dead in ui/packages/i18n/src/locales/*.ts. The keys the surviving PackagedActionsSection reads stay live.

Why it is not in #28578. The locale tables are typed, so removing keys narrows a published @object-ui/i18n surface: Clause-②: yes (narrowing), BREAKING, which owes a contract-tier review. N-28 keeps Clause-②: no.

Wanted. Remove exactly the keys check-i18n-dead-keys names dead under packagedAutomation.*, in every locale, with a BREAKING changeset carrying the FROM → TO note (no replacement; the page is retired, flows are switched in Studio). Also reword the comment at packages/services/service-automation/src/connector-credentials-ui.ts:12, which still names automation:packaged.

Reader. domain:ui, through triage, after #28578 lands. p3.

Dedup. packagedAutomation i18n dead keys → only #28578.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Nov 1, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#1 · zhuangjianguo · session_01QsR2jUJ19MstFvFhjgiYTu

    Added to this card · from #28578 PR 2 (PR #28818) · 2026-11-01T21:40Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: finding → pm:queue · 2026-11-02T08:09Z

    ⛔ Not a claim.


    Generated by Claude Code

  3. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#5 · zhuangjianguo · session_01QsR2jQjvWkZ7is6GXbC6DB

    Claim: PM loop round 3 · 2026-11-02T11:07Z
    Session: session_01QsR2jSHAUuvULZ3ZaDJbh2 (card thread, os-dev); dispatched by seat session session_01QsR2jQjvWkZ7is6GXbC6DB
    Account: zhuangjianguo
    Branch: claude/project-thread-o2wykx (platform-assigned to the card thread; it can push only this branch)
    Worktree: objectstack-issue-28789
    Domain: domain:ui
    Seat: domain:ui#5
    File surface: ui/packages/i18n/src/locales/*.ts (and namespaces/* only where the same keys live), the one comment line at packages/services/service-automation/src/connector-credentials-ui.ts:12, and a changeset (stop on breach)
    Container & model: S, mode:thread, model: default tier (no Fable per the maintainer's standing rule), effort: high
    Clause-②: yes (narrowing)
    Metadata-protocol: none
    Responsibility: dead packagedAutomation.* / layout.systemNav.objectManager / home.quickActions.manageObjects* keys stay in the published @object-ui/i18n tables after #28785 and #28818 retired their readers | check-i18n-dead-keys names them but nothing removes them | translators and every locale-touching PR carry keys no screen reads
    Thread-read: 6572227442
    Premise: holds (at origin/main 39951d2a, both parent PRs #28785 and #28818 are merged and the keys are still in en.ts; the dev measures check-i18n-dead-keys on main first and removes only what it names). Seat 1 (filer) handed it to seat 5, 11:02Z.
    Serial constraints cleared: locale packs are in open PRs #29257 (queued), #29266 and #29272; this PR merges main right before it opens and keeps both sides' additions. BREAKING changeset with the ADR-0087 marker; the CONTRACT_REVIEW_TIER review goes to the director, not self-reviewed.

  4. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#5 · zhuangjianguo · session_01QsR2jQjvWkZ7is6GXbC6DB

    Claim amended · 2026-11-02T11:10Z · on the os-dev's measurement at origin/main 39951d2a (/mnt/project-files/issue-28789/measure.md), before code. This amends claim 6575621235: the key set and the file surface. Branch, session, Clause-② and Metadata-protocol are unchanged.

    Clause-②: yes (narrowing)
    Metadata-protocol: none

    • Key set (option A, seat's ruling): all 28 keys that check-i18n-dead-keys names under the card's prefixes go in one BREAKING narrowing: 25 packagedAutomation.* (20 confirmed, plus 5 needs-review whose only footprint is CHANGELOG text or test comments), home.quickActions.manageObjects, home.quickActions.manageObjectsDesc and layout.systemNav.objectManager. No reader exists for any of them (a bare-leaf grep included). Leaving 7 behind would owe a second narrowing later.
    • Added to the surface: dead-key-batch-retired-4730.test.ts, where the two SURVIVING rows (lines 123, 131) leave, and de-quote-pairing-3876.test.ts, where the pinned pair count goes from 104 to 103 (lines 379, 456) with a history line, because cloneCreated's de value held a „{{name}}“ pair. Both are pins on the removed keys, not on behaviour.
  5. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:ui#5 · zhuangjianguo · session_01QsR2jSHAUuvULZ3ZaDJbh2
    os-dev-report

    {
     "issue": 28789,
     "status": "done",
     "branch": "claude/project-thread-o2wykx",
     "pr": "https://github.com/objectstack-ai/objectstack/pull/29359",
     "head": "ac6202e4",
     "session": "session_01QsR2jSHAUuvULZ3ZaDJbh2",
     "premise_still_valid": true,
     "summary": "Removed the 28 keys check-i18n-dead-keys names under packagedAutomation.* (20 CONFIRMED + 5 NEEDS-REVIEW), home.quickActions.manageObjects/manageObjectsDesc and layout.systemNav.objectManager from all ten @object-ui/i18n packs, per the seat's option A (amendment 6575664582). The two test pins that named them follow (4730 SURVIVING rows out; de-quote census 104 to 103). The connector-credentials-ui.ts docblock now names automation:packaged-actions. BREAKING changeset (patch, runtime-interface-only TranslationKeys disposition, removed-key table, no replacement). A CONTRACT_REVIEW_TIER review is owed for the narrowing and goes to the director through the seat; not self-reviewed.",
     "tests": "check-i18n-dead-keys: main 39951d2a 345 candidates (52 confirmed/293 needs-review), head 317 (31/286), 0 under the three prefixes. Reverse check on rebuilt i18n dist: probe in app-shell got TS2339 on packagedAutomation.cloneCreated and home.quickActions.manageObjects, actionsHeading compiled; probe deleted. vitest run packages/i18n/ at ac6202e4: 95/95 files, 1443 passed, 13 skipped. turbo type-check i18n+app-shell+console at ac6202e4: 73/73. en-drift exit 0, call-site-keys exit 0. No ablation: no tested runtime behaviour changed (data and pin edits only).",
     "gates": "dispatch-gates --commands at ccd69fb7: 63 families, all 63 exit 0 (ui vitest scripts/ 169 files passed, 2 skipped; type-check-debt under lock; dual-build-cjs-loads exit 3 before the full build, exit 0 after). --ran: 63 derived, 63 run, 0 NOT-MEASURED, 0 UNRUN. At ac6202e4: check-sdui-manifest 0, check:adr-0087-registration 0, body gates check-changeset-no-major 0, check-closing-keyword-parity 0, check-partof-closing-keyword 0. PR CI: in_progress at report time.",
     "dogfood_battery": "4672ff47 (the final head ac6202e4 only adds a main merge not touching this diff) · VERDICT command-exit 0 · Test Files 391/394 (3 skipped) · Tests 3223 passed, 28 skipped · no failures",
     "line_budget": "14 files, +45/-327 vs origin/main",
     "files_changed": [
      "ui/packages/i18n/src/locales/ar.ts",
      "ui/packages/i18n/src/locales/de.ts",
      "ui/packages/i18n/src/locales/en.ts",
      "ui/packages/i18n/src/locales/es.ts",
      "ui/packages/i18n/src/locales/fr.ts",
      "ui/packages/i18n/src/locales/ja.ts",
      "ui/packages/i18n/src/locales/ko.ts",
      "ui/packages/i18n/src/locales/pt.ts",
      "ui/packages/i18n/src/locales/ru.ts",
      "ui/packages/i18n/src/locales/zh.ts",
      "ui/packages/i18n/src/__tests__/dead-key-batch-retired-4730.test.ts",
      "ui/packages/i18n/src/__tests__/de-quote-pairing-3876.test.ts",
      "packages/services/service-automation/src/connector-credentials-ui.ts",
      ".changeset/28789-i18n-retire-packaged-flows-keys.md"
     ],
     "deviations": [
      "The two test files are in surface only by amendment 6575664582 (asked before editing). The connector-credentials-ui.ts edit spans lines 11-12 (one sentence: 'packaged-automation entry' became 'packaged-actions entry' on line 11 beside the ref on line 12). The en and zh packagedAutomation group comments were rewritten to describe the surviving actions page (comments inside the surface files)."
     ],
     "mcp_calls": "2 — GitHub MCP issue_read get and issue_read get_comments on card #28789; no GitHub MCP write",
     "api_writes": "2 — fleet-write pr_create (PR #29359); post-stamped comment on #28789 (this report). Plus git pushes.",
     "open_questions": [],
     "security_findings": "none",
     "out_of_scope_findings": []
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions