Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions resolver/detect_reparse_other.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
//go:build !windows

package resolver

// detectFileIsReparse is a no-op off Windows.
func detectFileIsReparse(path string) bool {
_ = path
return false
}
39 changes: 39 additions & 0 deletions resolver/detect_reparse_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
package resolver

import (
"os"
"path/filepath"
"testing"
)

func TestDetectFileIsReparseRegular(t *testing.T) {
path := filepath.Join(t.TempDir(), ".nvmrc")
if err := os.WriteFile(path, []byte("20.11.0\n"), 0o644); err != nil {
t.Fatalf("WriteFile: %v", err)
}
if detectFileIsReparse(path) {
t.Fatal("regular file reported as reparse")
}
}

func TestDetectFileIsReparseSymlink(t *testing.T) {
dir := t.TempDir()
target := filepath.Join(dir, "secret.txt")
link := filepath.Join(dir, ".nvmrc")
if err := os.WriteFile(target, []byte("token=leak\n"), 0o644); err != nil {
t.Fatalf("WriteFile: %v", err)
}
if err := os.Symlink(target, link); err != nil {
t.Skipf("symlink not permitted: %v", err)
}
if !detectFileIsReparse(link) {
t.Fatal("symlink detect file not reported as reparse")
}
}

func TestDetectFileIsReparseMissing(t *testing.T) {
path := filepath.Join(t.TempDir(), "missing.nvmrc")
if detectFileIsReparse(path) {
t.Fatal("missing path reported as reparse")
}
}
16 changes: 16 additions & 0 deletions resolver/detect_reparse_windows.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//go:build windows

package resolver

import "os"

// detectFileIsReparse reports symlink detect files so AutoUse does not follow
// planted links (nvm-sh GHSA-j6ch-mq5c-3h4x class). ModeSymlink covers the
// typical .nvmrc → secret file plant; junctions are uncommon for this vector.
func detectFileIsReparse(path string) bool {
info, err := os.Lstat(path)
if err != nil {
return false
}
return info.Mode()&os.ModeSymlink != 0
}
4 changes: 4 additions & 0 deletions resolver/resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ func ResolveActiveVersion(cwd ...string) (string, error) {
for _, file := range cfg.AutoDetect {
file = filepath.Join(wd, file)

if detectFileIsReparse(file) {
continue
}

if _, err := os.Stat(file); err == nil {
if raw, err := os.ReadFile(file); err == nil {
if strings.ToLower(filepath.Ext(file)) == ".json" {
Expand Down
Loading