Skip to content

fix: sign pnpm.mjs/yarn JS entrypoints for delegated trust - #30

Merged
coreybutler merged 1 commit into
mainfrom
fix/sign-pnpm-mjs
Nov 3, 2026
Merged

coreybutler merged 1 commit into
mainfrom
fix/sign-pnpm-mjs

Conversation

@coreybutler

Copy link
Copy Markdown
Contributor

Summary

  • Sign pnpm.mjs / pnpm.cjs / pnpm.js and yarn JS entrypoints in SignVersionScripts (same order proxy resolves).
  • Accept .mjs / .cjs in IsDelegatedLauncherPath so --sign-script can trust them.
  • Export PackageManagerCliRelPathsFor for CLI trust resign.

Fixes NVM4306 when proxy launches pnpm.mjs instead of the .cmd wrapper.

Test plan

  • go test ./verifycache -run 'IsDelegatedLauncherPath|SignVersionScriptsSignsPackageManager'
  • After pin: install node with global pnpm, run pnpm --version without NVM4306
  • nvm firewall trust module pnpm resigns nested pnpm.mjs

Proxy prefers pnpm.mjs over the .cmd wrapper, but SignVersionScripts only
trusted npm-cli.js / npx-cli.js / corepack.js. NVM4306 followed because the
resolved .mjs had no script-trust cache entry and IsDelegatedLauncherPath
rejected .mjs/.cjs for --sign-script.

Sign the same pnpm/yarn paths proxy resolves, accept .mjs/.cjs as delegated
launchers, and export PackageManagerCliRelPathsFor for trust resign.

Signed-off-by: Corey Butler <corey@author.io>
@coreybutler
coreybutler merged commit 6f3037b into main Nov 3, 2026
2 checks passed
@coreybutler
coreybutler deleted the fix/sign-pnpm-mjs branch November 3, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant