Repository navigation
fix: sign pnpm.mjs/yarn JS entrypoints for delegated trust - #30
Merged
Merged
Conversation
Proxy prefers pnpm.mjs over the .cmd wrapper, but SignVersionScripts only trusted npm-cli.js / npx-cli.js / corepack.js. NVM4306 followed because the resolved .mjs had no script-trust cache entry and IsDelegatedLauncherPath rejected .mjs/.cjs for --sign-script. Sign the same pnpm/yarn paths proxy resolves, accept .mjs/.cjs as delegated launchers, and export PackageManagerCliRelPathsFor for trust resign. Signed-off-by: Corey Butler <corey@author.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm.mjs/pnpm.cjs/pnpm.jsand yarn JS entrypoints inSignVersionScripts(same order proxy resolves)..mjs/.cjsinIsDelegatedLauncherPathso--sign-scriptcan trust them.PackageManagerCliRelPathsForfor CLI trust resign.Fixes NVM4306 when proxy launches
pnpm.mjsinstead of the.cmdwrapper.Test plan
go test ./verifycache -run 'IsDelegatedLauncherPath|SignVersionScriptsSignsPackageManager'pnpm --versionwithout NVM4306nvm firewall trust module pnpmresigns nestedpnpm.mjs