Repository navigation
fix: refuse drive-root children and foreign InstallRoot contents - #28
Merged
Merged
Conversation
Hard-deny InstallRoot when DataRoot would be a drive root (D:\tools), and when the folder already holds non-NVM apps. Uninstall may DelTree only dedicated version trees. Signed-off-by: Corey Butler <corey@author.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refuse Node InstallRoot when its parent is a drive root (
D:\tools), and when the folder already contains non-NVM content. TightenIsSafeToDeleteInstallRootso uninstall will not DelTree shared folders.Why
A user set storage to a shallow path under
D:\. DataRoot became the drive / shared tools folder; uninstall wiped sibling apps. We only warned on risky layout before; drive roots themselves were blocked, butD:\softwas allowed.Testing
go test ./fs(common)C:\nvm/D:\softdenied; nestedC:\nvm-tools\installsallowed; foreign vs version-only contentsRisk
Medium — users who intentionally used
D:\nvmas InstallRoot must move toD:\nvm\installs(or similar nesting). That layout was already unsafe (runtime on the drive root).