Skip to content

feat(link): honor RequireActivationSymlinks for activation links - #36

Merged
coreybutler merged 1 commit into
mainfrom
feat/require-activation-symlinks
Nov 16, 2026
Merged

coreybutler merged 1 commit into
mainfrom
feat/require-activation-symlinks

Conversation

@coreybutler

Copy link
Copy Markdown
Contributor

What

Link() creates symlinks only when RequireActivationSymlinks is set. ensureActivationLink recreates junctions as symlinks. Depends on nvm-windows/common#39.

Why

OpenSSH Redirection Guard blocks non-admin junctions on PATH (nvm#1564).

Testing

go test ./link/ ./bootstrap/ -run 'RequireActivation|MigratesJunction|LinkRequire|LinkDefault'

Risk

Low when default off. Enabling without symlink rights fails activation link creation (existing Dev Mode toast).

When the certified setting is on, create .nodejs / .link/nodejs as
symlinks only and migrate existing junctions on ensureActivationLink
so OpenSSH Redirection Guard can traverse PATH (nvm#1564).

Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
@coreybutler
coreybutler merged commit 1628b0f into main Nov 16, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant