Repository navigation
fix(uninstall): keep sibling prerelease installs distinct - #34
Merged
Merged
Conversation
NormalizeVersion stripped -alpha/-rc suffixes, so uninstalling one 27.0.0-alpha build removed every install sharing that x.y.z core and cleared the active sibling (nvm-windows/nvm#1561). Key identity by CanonicalVersion for exact uninstalls and active fallback selection.
coreybutler
added a commit
to nvm-windows/nvm
that referenced
this pull request
Nov 16, 2026
Pulls nvm-windows/cli#34 so uninstalling one Node.js alpha no longer removes sibling alphas that share the same x.y.z core (nvm#1561). Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
coreybutler
added a commit
to nvm-windows/nvm
that referenced
this pull request
Nov 16, 2026
Pulls nvm-windows/cli#34 so uninstalling one Node.js alpha no longer removes sibling alphas that share the same x.y.z core (nvm#1561). Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
coreybutler
added a commit
to nvm-windows/nvm
that referenced
this pull request
Nov 16, 2026
* chore: pin cli for exact prerelease uninstall matching Pulls nvm-windows/cli#34 so uninstalling one Node.js alpha no longer removes sibling alphas that share the same x.y.z core (nvm#1561). Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com> * chore: pin cli for exact prerelease uninstall matching Pulls nvm-windows/cli#34 so uninstalling one Node.js alpha no longer removes sibling alphas that share the same x.y.z core (nvm#1561). Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com> --------- Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CanonicalVersion(keeps-alpha/-rc), sonvm uninstall 27.0.0-alpha.0.0.0no longer matches every27.0.0-*folder.nvm-windows/nvm#1561).Test plan
go test ./installer/ -run 'TestFindInstalledVersionDirsKeepsSiblingPrereleasesDistinct|TestPrepareActiveForUninstallLeavesSiblingPrereleaseActive|TestPrepareActiveForUninstallChoosesLatestSemverFallback'27.0.0-alpha.0.0.0+27.0.0-alpha.0.1.0,nvm usethe latter,nvm uninstall 27.0.0-alpha.0.0.0— only the requested alpha is removed; active stays27.0.0-alpha.0.1.0.