Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/commands/pin.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package commands

import (
"bytes"
"common/fs"
"common/notify"
"common/resolver"
"common/settings"
Expand All @@ -18,6 +19,29 @@ import (
"github.com/iancoleman/orderedmap"
)

// refuseDetectFileReparse blocks writes through a planted symlink/.nvmrc (or
// other reparse point), matching the nvm-sh GHSA-8qjx-8r8m-mpqh class.
func refuseDetectFileReparse(path string) error {
info, err := os.Lstat(path)
if err != nil {
if os.IsNotExist(err) {
return nil
}
return err
}
if info.Mode()&os.ModeSymlink != 0 {
return fmt.Errorf("refusing to write %s: path is a symbolic link or reparse point", path)
}
reparse, err := fs.IsReparsePoint(path)
if err != nil {
return err
}
if reparse {
return fmt.Errorf("refusing to write %s: path is a symbolic link or reparse point", path)
}
return nil
}

type Pin struct {
Version string `arg:"" name:"version" help:"The version to set in the .nvmrc/package.json/etc file." optional:""`
File string `flag:"file" short:"f" help:"Determines which file to write the version to." placeholder:".nvmrc"`
Expand Down Expand Up @@ -131,6 +155,10 @@ func (c *Pin) Run() error {
npm_version = npmInfo.Version
}

if err := refuseDetectFileReparse(c.File); err != nil {
return err
}

switch strings.ToLower(c.File) {
case "package.json":
if _, err := os.ReadFile(c.File); err != nil {
Expand Down
44 changes: 44 additions & 0 deletions src/commands/pin_reparse_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
package commands

import (
"os"
"path/filepath"
"strings"
"testing"
)

func TestRefuseDetectFileReparseAllowsMissing(t *testing.T) {
path := filepath.Join(t.TempDir(), ".nvmrc")
if err := refuseDetectFileReparse(path); err != nil {
t.Fatalf("missing file: %v", err)
}
}

func TestRefuseDetectFileReparseAllowsRegularFile(t *testing.T) {
path := filepath.Join(t.TempDir(), ".nvmrc")
if err := os.WriteFile(path, []byte("20.11.0\n"), 0o644); err != nil {
t.Fatalf("WriteFile: %v", err)
}
if err := refuseDetectFileReparse(path); err != nil {
t.Fatalf("regular file: %v", err)
}
}

func TestRefuseDetectFileReparseRejectsSymlink(t *testing.T) {
dir := t.TempDir()
target := filepath.Join(dir, "secret.txt")
link := filepath.Join(dir, ".nvmrc")
if err := os.WriteFile(target, []byte("token=leak\n"), 0o644); err != nil {
t.Fatalf("WriteFile target: %v", err)
}
if err := os.Symlink(target, link); err != nil {
t.Skipf("symlink not permitted: %v", err)
}
err := refuseDetectFileReparse(link)
if err == nil {
t.Fatal("expected refusal for symlink detect file")
}
if !strings.Contains(err.Error(), "symbolic link or reparse point") {
t.Fatalf("error = %v, want reparse refusal", err)
}
}
Loading