Skip to content

Fix bug causing IIIF image slider view all links to be broken in AI mode#484

Merged
kdid merged 1 commit into
deploy/stagingfrom
ai-mode-slider-bug
Jun 12, 2026
Merged

Fix bug causing IIIF image slider view all links to be broken in AI mode#484
kdid merged 1 commit into
deploy/stagingfrom
ai-mode-slider-bug

Conversation

@kdid

@kdid kdid commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

When AI mode is enabled, the "View All" links on the IIIF image sliders are linking to a blank page of search results and behind the scenes the search query is returning a 400 error.

Root cause

The hybrid search request body included an inline search_pipeline definition alongside the ?search_pipeline=dc-v2-work-pipeline URL parameter. The API uses the URL parameter to specify the pipeline, and sending a conflicting inline definition in the body caused the 400.

Changes

  • Remove inline search_pipeline from request body as the URL parameter is the correct mechanism for this API and is sufficient on its own
  • Remove model_id from neural sub-query because the API injects the correct model ID server-side if not provided
  • Move facet filters inside hybrid sub-queries becasue post_filter applies after scoring, so filters on collection and subject weren't constraining the neural query's candidate pool; pushing them into each sub-query ensures the K nearest neighbors are drawn from the correct filtered set
  • Gate post_filter on non-AI queries which keeps existing filter behavior for standard keyword search unchanged

@kdid kdid self-assigned this Jun 12, 2026
@kdid kdid requested review from bmquinn and mbklein June 12, 2026 17:59
@kdid kdid merged commit 4c15891 into deploy/staging Jun 12, 2026
3 checks passed
@kdid kdid deleted the ai-mode-slider-bug branch June 12, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants