Include signed query string in awsFetch URL to fix SigV4 403s#389
Merged
Conversation
kdid
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
awsFetchbuilt the request URL ashttps://${signed.hostname}${signed.path}, dropping the query string. SigV4 includes the canonical query string in the signature, so any request with query params (e.g.?search_pipeline=dc-v2-work-pipeline) was signed with the query but sent without it. OpenSearch recomputed the signature from what it actually received and rejected the request:Fix
Build the fetch URL with
formatUrlfrom@aws-sdk/util-format-url(already a transitive dep of the SigV4 signer, now declared explicitly). It serializes the query string the same way@smithy/signature-v4does when signing, so the URL sent matches the URL signed.