fix(annotations): strictly prepend b64: to base64 encoded annotations#53
Open
Nachiket-Roy wants to merge 1 commit into
Open
fix(annotations): strictly prepend b64: to base64 encoded annotations#53Nachiket-Roy wants to merge 1 commit into
Nachiket-Roy wants to merge 1 commit into
Conversation
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
bunnycurrently blindly Base64-encodes all OCI annotations when writingurunc.json. This makes it impossible foruruncto safely distinguish between intended Base64 payloads and standard plaintext config labels without relying on unsafe heuristics.The Solution
This PR prepends a strict
"b64:"prefix to all encoded annotations generated inhops/package.go.This enables
urunc's new strict parser to safely decode these payloads without the risk of silently corrupting plaintext labels that happen to look like valid base64.context : urunc-dev/urunc#771