fix(tsnorm): survive parse errors, stop permanent raw passthrough (A-4)#13
Merged
Conversation
…raw passthrough A single astits parse error (one truncated UDP datagram, a corrupt adaptation field) killed the tsnorm demux goroutine: runDemux returned, demuxDone closed, and every later Process returned io.EOF while n.started stayed true — the worker then fell back to un-normalised raw passthrough forever, with no self-heal (raw bytes keep flowing so the stall watchdog never fires). This broke DASH AST/tfdt + HLS timing with a mid-stream PID/timestamp-domain change (A-4). - runDemux rebuilds the demuxer on a parse error and resyncs on the next sync byte, capped at maxDemuxRestarts=8 (mirrors pull.TSDemuxPacketReader). - Process resets n.started when it observes demuxDone, so a goroutine that does give up is relaunched lazily on the next call. Regression test TestProcess_RecoversFromParseError. Fixes audit finding A-4.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes audit finding A-4. A single astits parse error (one truncated UDP datagram / corrupt adaptation field) killed the tsnorm demux goroutine:
runDemuxreturned,demuxDoneclosed, and every laterProcessreturnedio.EOFwhilen.startedstayed true — the worker then fell back to un-normalised raw passthrough forever with no self-heal (raw bytes keep flowing so the stall watchdog never fires), breaking DASH AST/tfdt + HLS timing.runDemuxrebuilds the demuxer on a parse error and resyncs on the next sync byte, capped atmaxDemuxRestarts=8(mirrorspull.TSDemuxPacketReader).Processresetsn.startedwhen it observesdemuxDone, so a goroutine that does give up is relaunched lazily on the next call.A transient corruption now costs at most one passthrough chunk, not permanent un-normalised output. Test
TestProcess_RecoversFromParseError;go test -race+golangci-lintgreen.