Substitute words loaded from separate file, new additions by belliriccardo · Pull Request #9 · ntoll/arrr

belliriccardo · 2022-05-15T15:40:12Z

Made it such that new additions can just be appended at the end of the .csv file to keep the main file more clean. Also, there are plenty more substitutions. Arrr.

ntoll · 2022-05-15T15:50:11Z

Ahoy there @belliriccardo,

Welcome to the crew. ☠️

Ye have landed plenty'o shiny phrases in that there CSV.

But surely it should be a CSR file..? Ye say it, "Sea, yes! Arrr..!" (but I jest).

This'll need fixing up before we sail it to the PyPI lagoons. Anyone doing pip install arrr will need a treasure map to find the missing CSV file. Savvy..?

Summat for ye to patch up before we hoist this sail..? But happy to accept your contribution to the crew when patched.

Arrrrrr!

🏴‍☠️

belliriccardo · 2022-05-15T16:05:51Z

Ye're right matey, but I be missin' th' skill to package this altogether. If ye need me, I'll be in th' quarters below deck, cap'n...

ntoll · 2022-05-15T16:07:22Z

Aye. I'll keel haul this out in the coming week or so. 👍

belliriccardo · 2022-05-15T22:03:14Z

Disregard me last pigeon message, I 'ave figured it out! Should be jolly an' ready to go.

…ectly. Example: Before: "How are you?" -> "How be you?" Now: "How are you?" -> "How be ye?" Also don't de-capitalize words in the main dict so that names don't get lowercase'd (Ex. "Jack" -> "jack" inside a string of text no longer happens)

ntoll · 2022-05-16T17:00:57Z

Hmm... I've just tested it and it doesn't work. I think I know why, and will fix/check/merge when done. 👍

merwok · 2022-12-17T17:46:47Z

 CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 """
 import argparse as arrrgparse  # Geddit..? ;-)
+from csv import reader as HELMSMAN  # He be the only lad aboard who can read!


Why are ye screaming lads? helmsman be the good and usual way.

merwok · 2022-12-17T17:48:02Z

 #: MAJOR, MINOR, RELEASE, STATUS [alpha, beta, final], VERSION
-_VERSION = (1, 0, 3)
-
+_VERSION = (1, 1, 0)


Your editor be removing all them nice blank lines. Mates need restin betwen workin, ya know?

merwok · 2022-12-17T17:49:04Z

-}
-
+_PIRATE_WORDS = dict()
+with open('BLABBER.csv') as NONSENSE:


This here data file needs to be in yon package there mate, and ye be better usin pkgutil or importlib.resources to access it in a portable way!

merwok · 2022-12-17T17:49:39Z

        "Topic :: Communications",
        "Topic :: Software Development :: Internationalization",
    ],
+    include_package_data=True,


This here line is good but does nothin’ for now: yon CSV trove must be inside yon package to be included as package booty!

belliriccardo · 2022-12-19T10:29:07Z

Ahoy @merwok ! Me've forgotten a-boot(harharhar) this 'ere galley. Me've been' havin' a not so jolly time doin' me last pirate exams. About that there CSV file, I 'ave added it to th' MANIFEST.in file, I was thinkin' that was what was needed. If ye have any more comments or if I'm missin' somethin', feel free to tell! I'll go walk the plank now

merwok · 2022-12-19T14:57:01Z

Nah laddie, yon manifest is for loading extra cargo say readme and such into yon sdist barrel, but that’s not gonna install them there files! Trust me old head and move yon file into yon package, that’s what ye need to get it packaged and installed and accessed, yarr!

ntoll · 2022-12-21T14:48:13Z

Ahoy there mateys..!

@merwok you be an old sea dog full of packaging tales and lore for getting the booty in th'right place? Perchance you'd scrawl a treasure map for crew mate @belliriccardo to bury his CSV treasure in the right place? Yarrrrr...

Rum and a rebase may be needed too, before this plan can happen (but it sounds like a profitable piratical enterprise).

merwok · 2022-12-21T15:36:53Z

This here chart shows the way to get what I be sayin: belliriccardo#1

ntoll · 2022-12-23T15:34:26Z

Ahoy there me maties..! Merry Christmas and wishing you good plunderin' in the new year. Yarrrr.

If @belliriccardo lets @merwok's on board, I'll make it walk the plank into the shark infested waters o'this project.

turn module into package, fix packaging

belliriccardo · 2022-12-27T10:32:03Z

Allright! Sorry for me absence, ya know me've been plunderin' all these holidays! I 'ave merged @merwok pull request, sould be jolly now!

merwok

yo ho ho

merwok · 2022-12-27T16:49:33Z

 """

-
 #: MAJOR, MINOR, RELEASE, STATUS [alpha, beta, final], VERSION


Suggested change

#: MAJOR, MINOR, RELEASE, STATUS [alpha, beta, final], VERSION

#: MAJOR, MINOR, RELEASE, STATUS [alpha, beta, final], VERSION

merwok · 2022-12-27T16:49:42Z

 #: MAJOR, MINOR, RELEASE, STATUS [alpha, beta, final], VERSION
-_VERSION = (1, 0, 3)
-
+_VERSION = (1, 1, 0)


Suggested change

_VERSION = (1, 1, 0)

_VERSION = (1, 1, 0)

merwok · 2022-12-27T16:49:57Z


+del nonsense, gibberish

 #: A list of Pirate phrases to randomly insert before or after sentences.


Suggested change

#: A list of Pirate phrases to randomly insert before or after sentences.

#: A list of Pirate phrases to randomly insert before or after sentences.

merwok · 2022-12-27T16:51:55Z

                "Summat went awry, me lovely! Arrr..."
            )


Suggested change

"Summat went awry, me lovely! Arrr..."

)

"Summat went awry, me lovely! Arrr...",

file=sys.stderr,

)

Ye should complain on tha stderr room laddie!

merwok · 2022-12-27T16:52:49Z

+            "Ye filthy bilge rat, don't try to fool me! I will gut yer insides!"
+        )


Suggested change

"Ye filthy bilge rat, don't try to fool me! I will gut yer insides!"

)

"Ye filthy bilge rat, don't try to fool me! I will gut yer insides!",

file=sys.stderr,

)

sys.exit(1)

merwok · 2022-12-27T16:54:59Z

+you're,ye be
+you,ye
+your,yer
+yourself,yerself


Suggested change

yourself,yerself

yourself,yerself

merwok · 2022-12-27T17:04:02Z

-    "meeting": "parley with rum and cap'n",
-}
+_PIRATE_WORDS = dict()
+with open('BLABBER.csv') as nonsense:


Python landlubbers think it good practiss to eschew side effects at importin’ time, like openin’ and readin’ file.
That’s fine thinkin’ but it requires ye to go roundabout and add some init function like this here: https://github.com/python/cpython/blob/main/Lib/mimetypes.py#L336-L337

So me wonder what cap’n be thinkin’. Be fine to keep this simple if arrr be mainly a command-line program, not a module for other landlubbers to use.

Substitute words from separate file, new additions

44168c4

Add csv file in module

067ea98

belliriccardo added 4 commits May 16, 2022 10:04

Add csv file in module

0466edd

New words + Arrr misbehaviour with no arrrguments

3950f1d

New words

253ee54

merwok reviewed Dec 17, 2022

View reviewed changes

turn module into package, fix packaging

a583284

Merge pull request #1 from merwok-forks/feature/packaging

a1a92ce

turn module into package, fix packaging

merwok reviewed Dec 27, 2022

View reviewed changes

		"""


		#: MAJOR, MINOR, RELEASE, STATUS [alpha, beta, final], VERSION


		del nonsense, gibberish

		#: A list of Pirate phrases to randomly insert before or after sentences.

-                "Summat went awry, me lovely! Arrr..."
-            )
+                "Summat went awry, me lovely! Arrr...",
+                file=sys.stderr,
+            )

		"Ye filthy bilge rat, don't try to fool me! I will gut yer insides!"
		)

Conversation

belliriccardo commented May 15, 2022

Uh oh!

ntoll commented May 15, 2022

Uh oh!

belliriccardo commented May 15, 2022

Uh oh!

ntoll commented May 15, 2022

Uh oh!

belliriccardo commented May 15, 2022

Uh oh!

ntoll commented May 16, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

merwok Dec 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

belliriccardo commented Dec 19, 2022

Uh oh!

merwok commented Dec 19, 2022

Uh oh!

ntoll commented Dec 21, 2022

Uh oh!

merwok commented Dec 21, 2022

Uh oh!

ntoll commented Dec 23, 2022

Uh oh!

belliriccardo commented Dec 27, 2022

Uh oh!

merwok left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

merwok Dec 17, 2022 •

edited

Loading