fix(reify): report added count for fresh linked installs#9661
Merged
owlstronaut merged 1 commit intoJun 25, 2026
Merged
Conversation
owlstronaut
approved these changes
Jun 25, 2026
Contributor
|
🎉 Backport to |
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
install-strategy=linked, a freshnpm installthat actually creates.storeentries and symlinks printedup to date, audited N packagesinstead ofadded N packages, misleading users and CI into thinking nothing changed.reify-outputcounts adds withactualTree.inventory.has(d.ideal). Under the linked strategy the diff'sidealnodes belong to the isolated store tree (locations undernode_modules/.store/<key>/node_modules/<name>), while theactualTreereturned after reify is the logical hoisted-layout tree. The two never share node identity, so the lookup always failed andaddedstayed0.The ADD branch now also counts a node when it is a real store package node (
isInStore && !isLink), which maps 1:1 to a hoisted package add. This excludes the internal store symlinks and the top-level consumer symlink, so the count matches hoisted for registry dependencies (verified:minimatch4/4,rimraf12/12,express69/69). Omitted/incompatible optional deps have no store entry and are still not counted, and hoisted behavior is unchanged.Known limitations (tracked separately): workspace and
file:/npm linkadditions are represented as links rather than store nodes under linked, so they are not yet counted here — counting them is entangled with the self-link bug (#9398) and the undeclared-workspaces bug (#9618). The--jsonadd[].pathfor a counted store package points to its.storerealpath rather than a logicalnode_modules/<name>path.References
Fixes #9623