fix(arborist): load transitive optional deps into linked actual tree#9654
Merged
owlstronaut merged 1 commit intoJun 25, 2026
Merged
Conversation
owlstronaut
approved these changes
Jun 25, 2026
Contributor
|
🎉 Backport to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In continuation of our exploration of using
install-strategy=linkedin the Gutenberg monorepo, which powers the WordPress Block Editor.Under
install-strategy=linked, an installed transitive optional dependency was missing from the actual tree built byloadActualwhen scanning the filesystem (forceActual: true), the pathnpm sbomandnpm queryuse. On disk the dep is correct — extracted in.storeand symlinked as a store sibling of its consumer — butnpm sbomomitted it (e.g.chokidar→fsevents: 14 components vs the hoisted strategy's 15;esbuild→@esbuild/darwin-arm64likewise).In
#findMissingEdges(), the skip condition treated an edge as already resolved when!edge.missing. An unresolved optional edge has no target yet reportsmissing === false(Edge.errorreturnsnullfor an optional edge with no target), so it was skipped and the on-disk store sibling was never walked or loaded.This changes the check to walk any edge whose target is unresolved, including optional ones. The walk only loads a package that actually exists in an ancestor
node_modules, so genuinely-uninstalled optionals (impossible platform) stay absent, and behavior is unchanged for required, missing, dummy, and hoisted-ancestor edges. The linked SBOM now matches the hoisted strategy.References
Fixes #9627