Skip to content

Upgraded Python version support to recent versions#241

Merged
claudep merged 3 commits into
notanumber:masterfrom
claudep:upgradepython
Mar 18, 2026
Merged

Upgraded Python version support to recent versions#241
claudep merged 3 commits into
notanumber:masterfrom
claudep:upgradepython

Conversation

@claudep

@claudep claudep commented Mar 15, 2026

Copy link
Copy Markdown
Collaborator

Dropped Python 3.7, 3.8, 3.9 (EOL).
Added Python 3.11, 3.12, 3.13

@claudep

claudep commented Mar 15, 2026

Copy link
Copy Markdown
Collaborator Author

@asedeno, do you think you would be able to help us make the xapian build step pass again?

@asedeno

asedeno commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

It works fine with Xapian 1.4.20, and Xapian 1.4.31 (latest).

@claudep
claudep force-pushed the upgradepython branch 2 times, most recently from 7d1280a to d931689 Compare March 16, 2026 07:54
@claudep

claudep commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator Author

Ah yes, the prebuilding step now passes, thanks a lot! I will try to work on on other issues.

claudep added 2 commits March 17, 2026 21:45
Dropped Python 3.7, 3.8, 3.9 (EOL).
Added Python 3.11, 3.12, 3.13
@claudep

claudep commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator Author

@asedeno, the coveralls step fails, and I don't see how to fix it. Do we really need that coveralls stuff?

@asedeno

asedeno commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

This seems to be related to the PYTHONPATH stuff, which was copied over from the old travis CI config.
We do need . in PYTHONPATH for a bunch of stuff to work. I'm looking into how to better do this now.

@asedeno asedeno left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a shot. Adding /usr/lib/python3/dist-packages to PYTHONPATH is weird, and when I did that I could replicate the issue we're seeing in tests. I think the only thing we were getting out of there is packaging, which is a django-haystack dependency we are not installing. Let's install it and get rid of this hack.

Comment thread .github/workflows/test.yml Outdated
Comment thread .github/workflows/test.yml Outdated
Comment thread .github/workflows/test.yml Outdated
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 97.588% (+0.02%) from 97.565%
when pulling c53e06b on claudep:upgradepython
into 30c727e on notanumber:master.

@claudep

claudep commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator Author

@asedeno You are my hero 🏅 Thanks a lot.

@claudep
claudep merged commit 5eec1ff into notanumber:master Mar 18, 2026
24 checks passed
@claudep
claudep deleted the upgradepython branch March 18, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants