Limit content search#200
Draft
asedeno wants to merge 2 commits into
Draft
Conversation
asedeno
marked this pull request as draft
September 20, 2021 15:55
As per the haystack documentation [1] the `content` field is a special term for the field marked `document=True`. This change impements that behavior. [1] https://django-haystack.readthedocs.io/en/master/searchqueryset_api.html#the-content-shortcut
asedeno
force-pushed
the
limit-content-search
branch
from
September 27, 2021 04:40
1d3be9d to
b2f2ba3
Compare
Collaborator
Author
|
Rebased so we can get all the test coverage stuff running on the branch. As mentioned in the previous iteration of this PR, it breaks tests. I believe those tests are broken by design because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the haystack documentation [1] the
contentfield is a special term for the field markeddocument=True. This change implements that behavior.[1] https://django-haystack.readthedocs.io/en/master/searchqueryset_api.html#the-content-shortcut
This reopens #182 on a topic branch.
NB: This has been rebased onto master as of now, but has not been re-tested at all. Consider it a draft starting point to consider the issue.