Accept string based primary keys

[charles-vdulac]

[fixes issue #138 ]
[closes pr #157 ]

[coveralls]

Coverage decreased (-0.06%) to 96.576% when pulling b7c8eed on charles-vdulac:master into f46283b on notanumber:master.

[coveralls]

Coverage increased (+0.2%) to 96.799% when pulling 13c1e02 on charles-vdulac:master into f46283b on notanumber:master.

[jorgecarleitao]

Why isn't this ['uuid-1', 'uuid-2', 'uuid-3']? I thought that the goal was to ensure PK is a string.

[jorgecarleitao]

Overall, I like the proposed change a lot. Could you squash 13c1e02 into b7c8eed so we have a single commit with all the relevant changes regarding this new addition? It is also easier to review it.

[coveralls]

Coverage increased (+0.1%) to 96.784% when pulling 7929436 on charles-vdulac:master into f46283b on notanumber:master.

[coveralls]

Coverage increased (+0.1%) to 96.784% when pulling 7929436 on charles-vdulac:master into f46283b on notanumber:master.

[coveralls]

Coverage increased (+0.1%) to 96.784% when pulling 7929436 on charles-vdulac:master into f46283b on notanumber:master.

[jorgecarleitao]

I believe the PR is almost ready to merge.

As far as I understood, right now this tests the indexation (changes to test_backend), the ordering (test_order_by_django_id), and the correct generation of the query (test_filter_string_based_django_pk).

I believe that one final addition is to test the search interface, that is roughly present in test_interface.py. E.g. a test like this

self.assertEqual(pks(self.queryset.filter(id='uuid-1')),
                 pks(Document.objects.filter(django_id__eq='uuid-1')))

(see here for examples)

This would check that a search by id in Xapian corresponds to a search by id in Django's ORM, as we would expect.

You can also add your name to the credits in the README, as part of this commit.

Other than that, the code is clean and explicit, and, for me, this is ready to merge.

Thanks a lot @charles-vdulac for this!

[coveralls]

Coverage increased (+0.5%) to 99.589% when pulling affe3d9 on charles-vdulac:master into f67036e on notanumber:master.

[coveralls]

Coverage increased (+0.5%) to 99.589% when pulling affe3d9 on charles-vdulac:master into f67036e on notanumber:master.

[coveralls]

Coverage increased (+0.5%) to 99.589% when pulling affe3d9 on charles-vdulac:master into f67036e on notanumber:master.

[charles-vdulac]

Hi @jorgecarleitao Sorry for this long delay. I just merge your PR and rebased the branch to make it up to date.

[ciur]

Would it be possible to make this pull request as part of the next release ?