cel: Add process annotation functions - #1191
russellhancox wants to merge 5 commits into
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (14)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughCELv2 now supports ChangesCEL Process-Tree Annotations
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant CELActivation
participant AnnotationFunction
participant ProcessTree
participant CELAnnotator
CELActivation->>AnnotationFunction: Evaluate has_annotation or add_annotation
AnnotationFunction->>ProcessTree: Read or stage annotation for exec target
ProcessTree->>CELAnnotator: Query or replace annotation state
ProcessTree->>CELAnnotator: Propagate annotations across fork or exec
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Adds add_annotation and has_annotation functions to CEL, which add & retrieve annotations on the process tree.
This does not hook annotations into telemetry (that will be a follow-up PR) nor does it include pre-defined annotations (another follow-up PR once we've decided what those should be).