Skip to content

Fix text rendering, update dependencies for new purescript#2

Open
marcusbuffett wants to merge 1 commit into
nonbili:masterfrom
marcusbuffett:master
Open

Fix text rendering, update dependencies for new purescript#2
marcusbuffett wants to merge 1 commit into
nonbili:masterfrom
marcusbuffett:master

Conversation

@marcusbuffett

Copy link
Copy Markdown

Tried to use this to convert Streamline icons recently and had a couple stumbling blocks. Fixed the text node rendering to wrap stuff in quotes, and updated dependencies so the project builds with latest purescript. I have purty installed so it looks like a lot of changes in Render.purs but the only real change is:

 renderSvgNode _ (SvgText str) = "text " <> "\"\"\"" <> str <> "\"\"\""

@marcusbuffett

Copy link
Copy Markdown
Author

Oh and thank you for creating this! Saved me a lot of trouble trying to embed the svgs myself

@rnons

rnons commented May 11, 2020

Copy link
Copy Markdown
Contributor

Hi, thanks for your pull request. Do you mind reverting the changes introduced by purty? I haven't tried purty yet. I'm more familiar with the old formatting, and will work on #1 some time, which may introduce some inconsistency with purty formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants