Skip to content

Fix potential name clash when used as dependency #163

Merged
fdelesma merged 4 commits into
mainfrom
fix_nameclash
Apr 16, 2026
Merged

Fix potential name clash when used as dependency #163
fdelesma merged 4 commits into
mainfrom
fix_nameclash

Conversation

@moritzleucke

@moritzleucke moritzleucke commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator
  • modules "kinds" and "constants" are commen in other builds
  • if greenX is a dependency then this could create conflicts in the build
  • renamed the modules "gx_kinds" and "gx_constants"

Aditionally: updated the python version so that the CI works again

@moritzleucke moritzleucke requested a review from fdelesma April 16, 2026 13:09
fdelesma
fdelesma approved these changes Apr 16, 2026
View reviewed changes

@fdelesma fdelesma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdelesma fdelesma requested a review from JWilhelm April 16, 2026 14:15
@moritzleucke moritzleucke requested a review from ekinesme April 16, 2026 14:18
@fdelesma fdelesma merged commit cbe82a7 into main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdelesma fdelesma fdelesma approved these changes
@ekinesme ekinesme ekinesme approved these changes
@JWilhelm JWilhelm Awaiting requested review from JWilhelm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moritzleucke @fdelesma @ekinesme