forked from openshift/installer
-
Notifications
You must be signed in to change notification settings - Fork 1
DNM - Jefferson to release-4.4 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snaiksat
wants to merge
67
commits into
release-4.4
Choose a base branch
from
jefferson
base: release-4.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
35f9989
First commits for ACI CNI
6afddb9
Initial Commit: Adding scripts to update Ignition files
abhis2112 b451e52
Make ACI tasks conditional
5120a8e
Seperate floating IP playbooks for non-bootstrap nodes
75add5c
Separate playbook for CiscoACI variables and minor changes
4a464f5
Read CiscoACI fields from inventory and minor fixes
12c8cb3
Updating update_boot.py to include changes for OCP-release-4.4
abhis2112 1fa6b29
Allowed address pairs not required for second port
300ae16
Changes to user input, SGs, field names
34205b2
Missing CiscoACI condition for pod net SG
6a344fe
Consolidating the scripts to update ignition files into one single file
abhis2112 0e3bce6
Adding relevant change to compute nodes playbook to facilitate multip…
abhis2112 6d508d4
Fix typo and missing neutron_network_mtu,service_vlan in network play…
d4dc7e8
Changes added to playbooks to resolve issues related
abhis2112 96ac225
Refactor to change ACI CNI inventory fields, tasks and SGs
3492da6
Post-install step to create cluster SNAT policy
d26c039
Set MTU for node network
b163209
Fix minor typo in network Ansible task
8ddb074
Remove prefix-length arg from subnet creation task
dce1f04
Create node network with epg contract relationship
1b7d597
Set primaryClusterNetwork tag on node network
9720b7f
Load app_profile name from acc-provision tar file
848d510
Add neutron network extension for node BD
dfe1018
Adding second interface configuration in worker machineset
abhis2112 b86b5fb
Missing brackets in network playbook and sample inventory file
3ea9cff
Add network scripts for control and compute nodes to bootstrap.ign
6897f74
Set default node_epg
8b2a348
Set defaults for network interface fields
f924a7e
Fix network task to set mtu
4810113
Merge pull request #87 from noironetworks/mtu-fix
snaiksat b7a2642
Renaming the acicontainers network in alphabetical order to come afte…
abhis2112 f41f369
Merge pull request #88 from noironetworks/abhi-rename-network
snaiksat 1caa5c9
Adding MachineConfig to disable MCO Disk Validation Check
abhis2112 f23d568
Merge pull request #89 from noironetworks/abhi-disable-mco-check
a806a61
Adding functionality to create the bootstrap shim ignition file
abhis2112 ab4b712
Merge pull request #90 from noironetworks/abhi-boostrap-shim-add
6ee19ea
Adding the post-install steps for the Cluster and renaming files
abhis2112 5da1fb7
Merge pull request #91 from noironetworks/abhi-post-install
snaiksat 8cc0621
Move dns_ip field under aci_cni and make related task conditional
6243629
Merge pull request #92 from noironetworks/dnsip
snaiksat 45e7d39
Clarifying sample config in inventory.yaml
snaiksat 3884823
Merge pull request #93 from noironetworks/update-sample-inventory
78c7042
Adding relevant changes to file update_ign.py for running it via pyth…
abhis2112 de637b2
Delete .down-02_network.yaml.swp
6eee308
Merge pull request #95 from noironetworks/apoorva11029-patch-1
abhis2112 dba1491
make down network tasks more resilient
jeichler 5ef9b84
fix listing of cluster address scope in down network playbook
jeichler 9ace8dc
directly use k8s to create the cluster snat policy from a template
jeichler 101a46c
fix typo
jeichler de07e9d
add support for multiple dns ips
jeichler ec777b4
use k8s for ingresscontroller
jeichler 36c196f
Correct the subnet name when setting dns ip for secondary network
803d850
Merge pull request #104 from noironetworks/dnsip
snaiksat c8c9fd9
Merge branch 'jefferson' into support_multiple_dns_ips
snaiksat e639da0
Merge pull request #102 from jeichler/support_multiple_dns_ips
snaiksat 2cfa653
Merge pull request #94 from noironetworks/abhi-python3-fix
snaiksat 15c42e3
Merge pull request #97 from jeichler/down_network_improvements
snaiksat 916c301
Merge pull request #98 from jeichler/snatpolicy_use_template_in_k8s
snaiksat caece06
Merge pull request #103 from jeichler/use_k8s_for_ingresscontroller
snaiksat a0444f6
Moving the functionality to update the 99_openshift-cluster-api_worke…
abhis2112 94e966e
Merge pull request #105 from noironetworks/abhi-mc-update
snaiksat 753b4a6
Adding primaryClusterNetwork tag to primary network
abhis2112 91dac83
Merge pull request #106 from noironetworks/abhi-tag
snaiksat 7826cfd
Removing the dependency of disabling MCO check
abhis2112 a847201
Merge pull request #112 from noironetworks/abhi-mco-check-remove
abhis2112 0eb11e2
Removing the dependency of opflex interface from the bootstrap machine.
abhis2112 d6c4d53
Merge pull request #115 from noironetworks/abhi-bootstrp-fix
snaiksat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| - import_playbook: common.yaml | ||
|
|
||
| - hosts: all | ||
| gather_facts: no | ||
|
|
||
| tasks: | ||
| - name: 'Create ACI containers node network' | ||
| command: | ||
| cmd: "neutron net-create {{ os_aci_containers_network }} --apic:nested-domain-name openshift-domain --apic:nested-domain-type openshift --apic:nested_domain_infra_vlan {{ aci_cni['infra_vlan'] }} --apic:nested_domain_service_vlan {{ aci_cni['service_vlan'] }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Set the ACI containers cluster network tag' | ||
| command: | ||
| cmd: "openstack network set --tag {{ cluster_id_tag }} {{ os_aci_containers_network }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Create the ACI containers subnet' | ||
| os_subnet: | ||
| name: "{{ os_aci_containers_subnet }}" | ||
| network_name: "{{ os_aci_containers_network }}" | ||
| no_gateway_ip: yes | ||
| cidr: "{{ aci_cni['network_interfaces']['opflex']['subnet'] }}" | ||
| allocation_pool_start: "{{ aci_cni['network_interfaces']['opflex']['subnet'] | next_nth_usable(10) }}" | ||
| allocation_pool_end: "{{ aci_cni['network_interfaces']['opflex']['subnet'] | ipaddr('last_usable') }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Set the ACI containers cluster subnet tag' | ||
| command: | ||
| cmd: "openstack subnet set --tag {{ cluster_id_tag }} {{ os_aci_containers_subnet }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Set MTU for the ACI containers network' | ||
| command: | ||
| cmd: "openstack network set {{ os_aci_containers_network }} --mtu {{ aci_cni['network_interfaces']['opflex']['mtu'] }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Set dns nameserver' | ||
| command: | ||
| cmd: "openstack subnet set --dns-nameserver {{ item }} {{ os_subnet }}" | ||
| when: | ||
| - os_networking_type == "CiscoACI" | ||
| - aci_cni.dns_ips is defined and aci_cni.dns_ips | length > 0 | ||
| with_items: "{{ aci_cni.dns_ips }}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,18 +14,44 @@ | |
| - name: 'Create the cluster network' | ||
| os_network: | ||
| name: "{{ os_network }}" | ||
| when: os_networking_type != "CiscoACI" | ||
|
|
||
| - name: 'Create the cluster network with aci-containers-nodes EPG contract relationship for node network' | ||
| command: | ||
| cmd: "neutron net-create {{ os_network }} --apic:epg_contract_masters list=true type=dict app_profile_name={{ aci_cni['app_profile'] }},name={{ aci_cni['node_epg'] }} --apic:distinguished_names type=dict BridgeDomain={{ aci_cni['network_interfaces']['node']['bd'] }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Set the cluster network tag' | ||
| command: | ||
| cmd: "openstack network set --tag {{ cluster_id_tag }} {{ os_network }}" | ||
|
|
||
| - name: 'Set the primaryClusterNetwork tag' | ||
| command: | ||
| cmd: "openstack network set --tag {{ os_network }} {{ os_network }}" | ||
|
|
||
| - name: 'Create a subnet' | ||
| os_subnet: | ||
| name: "{{ os_subnet }}" | ||
| network_name: "{{ os_network }}" | ||
| cidr: "{{ os_subnet_range }}" | ||
| allocation_pool_start: "{{ os_subnet_range | next_nth_usable(10) }}" | ||
| allocation_pool_end: "{{ os_subnet_range | ipaddr('last_usable') }}" | ||
| when: os_networking_type != "CiscoACI" | ||
|
|
||
| - name: 'Create the cluster address-scope' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This two tasks can probably be moved to the 021_network.yaml and again include that file only for |
||
| command: | ||
| cmd: "neutron address-scope-create node_network_address_scope 4 --apic:distinguished_names type=dict VRF={{ aci_cni['network_interfaces']['node']['vrf'] }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Create the subnetpool' | ||
| command: | ||
| cmd: "neutron subnetpool-create --pool-prefix {{ os_subnet_range }} --address-scope node_network_address_scope node_network_subnet_pool" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Create a subnet' | ||
| command: | ||
| cmd: "openstack subnet create --network {{ os_network }} --subnet-pool node_network_subnet_pool --subnet-range {{ os_subnet_range }} --allocation-pool start={{ os_subnet_range | next_nth_usable(10) }},end={{ os_subnet_range | ipaddr('last_usable') }} --dhcp {{ os_subnet }}" | ||
| when: os_networking_type == "CiscoACI" | ||
|
|
||
| - name: 'Set the cluster subnet tag' | ||
| command: | ||
|
|
@@ -151,3 +177,8 @@ | |
| - name: 'Attach the Ingress floating IP to Ingress port' | ||
| command: | ||
| cmd: "openstack floating ip set --port {{ os_port_ingress }} {{ os_ingress_fip }}" | ||
|
|
||
| - name: 'Set MTU for the node network' | ||
| command: | ||
| cmd: "openstack network set {{ os_network }} --mtu {{ aci_cni['network_interfaces']['node']['mtu'] }}" | ||
| when: os_networking_type == "CiscoACI" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| - hosts: all | ||
| gather_facts: no | ||
| tasks: | ||
|
|
||
| - name: 'Create cluster SNAT policy' | ||
| k8s: | ||
| state: present | ||
| kubeconfig: "{{ aci_cni['kubeconfig'] }}" | ||
| definition: "{{ lookup('template', 'cluster_snat_policy.conf.j2') }}" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| - name: 'Compute CiscoACI resource names' | ||
| set_fact: | ||
| os_aci_containers_network: "{{ infraID }}-secondaryClusterNetwork-acicontainers" | ||
| os_aci_containers_subnet: "{{ infraID }}-acicontainers-nodes" | ||
| os_aci_containers_port_bootstrap: "{{ infraID }}-acicontainers-bootstrap-port" | ||
| os_aci_containers_port_master: "{{ infraID }}-acicontainers-master-port" | ||
| os_aci_containers_port_worker: "{{ infraID }}-acicontainers-worker-port" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
upi/openstack/files/ingresscontroller_internal_loadbalancer.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| apiVersion: operator.openshift.io/v1 | ||
| kind: IngressController | ||
| metadata: | ||
| namespace: openshift-ingress-operator | ||
| name: default | ||
| spec: | ||
| endpointPublishingStrategy: | ||
| type: LoadBalancerService | ||
| loadBalancer: | ||
| scope: Internal |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as before. you could remove all of the "When: os_networking_type == "CiscoACI" and simply include this file in 02_network.yaml with a when clause:
like so:
incluce: 021_network.yaml <--I woudl also change name to show it is for ciscoACI
when: os_networking_type == "CiscoACI"
saves typing all those when, and its easier to review and matain.