Skip to content

benchmark: fix url-searchparams-sort to sort a fresh list - #66535

Closed
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix-url-searchparams-sort-to-sort-a-fresh-list
Closed

benchmark: fix url-searchparams-sort to sort a fresh list#66535
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix-url-searchparams-sort-to-sort-a-fresh-list

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

As titled.

# before
type='empty' n=200000: 57,300,000
type='sorted' n=200000: 32,700,000
type='reversed' n=200000: 33,100,000
type='random' n=200000: 33,000,000
type='long' n=200000: 15,300,000

# after
type='empty' n=200000: 25,400,000
type='sorted' n=200000: 7,800,000
type='reversed' n=200000: 1,200,000
type='random' n=200000: 2,000,000
type='long' n=200000: 420,000

@RafaelGSS
benchmark: fix url-searchparams-sort to sort a fresh list
42202c8 
Copying from another URLSearchParams only slices its internal list,
so every iteration sorts a fresh, unsorted copy.

Refs: nodejs#50566
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS marked this pull request as ready for review October 5, 2026 14:49
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Oct 5, 2026
@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 8, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ✖    - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/37327902422/job/111823228812)
   ✖    - lint-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823231551)
   ✖    - lint-addon-docs: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823231988)
   ✖    - lint-js-and-md: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823232004)
   ✖    - format-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823232590)
   ✖    - build-tarball: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902666/job/111823229499)
   ✖    - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902666/job/111823969721)
   ✖    - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902928/job/111823230273)
   ✖    - Build slim tarball: CANCELLED (https://github.com/nodejs/node/actions/runs/37327903789/job/111823232980)
   ✖    - aarch64-linux: Cache V8 build: CANCELLED (https://github.com/nodejs/node/actions/runs/37327903789/job/111824015372)

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
�[36m⠋�[39m Loading data for nodejs/node/pull/66535
�[36m⠋�[39m Loading data for nodejs/node/pull/66535
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66535
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66535
�[36m⠋�[39m Getting comments from nodejs/node/pull/66535
�[36m⠋�[39m Getting commits from nodejs/node/pull/66535
✔  Done loading data for nodejs/node/pull/66535
----------------------------------- PR info ------------------------------------
Title      benchmark: fix url-searchparams-sort to sort a fresh list (#66535)
Author     Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch     RafaelGSS:fix-url-searchparams-sort-to-sort-a-fresh-list -> nodejs:main
Labels     url, benchmark, whatwg-url, author ready, commit-queue
Commits    1
 - benchmark: fix url-searchparams-sort to sort a fresh list
Committers 1
 - RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/66535
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66535
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 05 Oct 2026 14:49:39 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/66535#pullrequestreview-5448063563
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/66535#pullrequestreview-5462000027
   ✖  13 GitHub CI job(s) cancelled:
   ✖    - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902335/job/111823233973)
   ✖    - build-docs: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902367/job/111823228424)
   ✖    - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/37327902422/job/111823228395)
   ✖    - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/37327902422/job/111823228812)
   ✖    - lint-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823231551)
   ✖    - lint-addon-docs: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823231988)
   ✖    - lint-js-and-md: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823232004)
   ✖    - format-cpp: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902584/job/111823232590)
   ✖    - build-tarball: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902666/job/111823229499)
   ✖    - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902666/job/111823969721)
   ✖    - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/37327902928/job/111823230273)
   ✖    - Build slim tarball: CANCELLED (https://github.com/nodejs/node/actions/runs/37327903789/job/111823232980)
   ✖    - aarch64-linux: Cache V8 build: CANCELLED (https://github.com/nodejs/node/actions/runs/37327903789/job/111824015372)
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

RafaelGSS added a commit that referenced this pull request Oct 8, 2026
@RafaelGSS
benchmark: fix url-searchparams-sort to sort a fresh list
dd9777b 
Copying from another URLSearchParams only slices its internal list,
so every iteration sorts a fresh, unsorted copy.

Refs: #50566
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #66535
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@RafaelGSS

RafaelGSS commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

Landed in dd9777b

@RafaelGSS RafaelGSS closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RafaelGSS @nodejs-github-bot @lpinca @UlisesGascon