doc,lib,src: throw on missing WebAssembly or RX support - #66533
Open
ShogunPanda wants to merge 1 commit into
Open
ShogunPanda wants to merge 1 commit into
ShogunPanda wants to merge 1 commit into
Conversation
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
aduh95
reviewed
Oct 5, 2026
Comment on lines
+6
to
+8
| if (typeof WebAssembly !== 'undefined') { | ||
| skip('WebAssembly is available in jitless mode'); | ||
| } |
Contributor
There was a problem hiding this comment.
Hum I don't think we should add that, if V8 makes a change so that wasm is available even with --jitless, I think we definitely want to detect it
Contributor
Author
|
Undici PR: nodejs/undici#5966 |
ronag
approved these changes
Oct 5, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66533 +/- ##
==========================================
- Coverage 92.74% 90.39% -2.35%
==========================================
Files 422 791 +369
Lines 193170 276006 +82836
Branches 29783 52980 +23197
==========================================
+ Hits 179160 249507 +70347
- Misses 13682 16910 +3228
- Partials 328 9589 +9261
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Oct 5, 2026
| V(ERR_OPERATION_FAILED, TypeError) \ | ||
| V(ERR_OPTIONS_BEFORE_BOOTSTRAPPING, Error) \ | ||
| V(ERR_OUT_OF_RANGE, RangeError) \ | ||
| V(ERR_RX_MEMORY_NOT_SUPPORTED, Error) \ |
Contributor
There was a problem hiding this comment.
\ needs one more character indentation 🤤
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When WebAssembly or RX memory are not available, eventually due to
--jitless, a catchable error is now thrown.In the docs is also clearly stated that if a feature requires one of the features above, Node.js guarantess no fallback.
Changes
ERR_WEBASSEMBLY_NOT_SUPPORTEDfor WASM module imports, including source-phase imports.ERR_RX_MEMORY_NOT_SUPPORTEDfor otherwise eligible FFI Fast API functions when the executable-memory probe fails.Notes
A Undici / Fetch similar change is deferred to a separate upstream change.
Assisted-By: OpenAI:GPT-6.1 Sol <openai/gpt-6.1-sol>