Repository navigation
quic/stream: create gen. getWriter for stream/iter - #66513
martenrichter wants to merge 2 commits into
Conversation
|
Review requested:
|
|
@jasnell @pimterry |
|
P.S.: There seem to be some bugs remaining. (I thought I had run all tests, but it seems that I only ran lint and not a full build.) But discussing the structure should work anyway. |
2f1920c to
40db343
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66513 +/- ##
==========================================
+ Coverage 90.41% 90.43% +0.01%
==========================================
Files 791 792 +1
Lines 275567 276692 +1125
Branches 52835 53110 +275
==========================================
+ Hits 249159 250224 +1065
- Misses 16813 16861 +48
- Partials 9595 9607 +12
🚀 New features to boost your workflow:
|
The get writer method of QuicStream is mostly generell enough to be usuable in other contexts. This PR is an attempt to move the code out of the QuicStream object to be usuable in other parts of node.js. Fixes nodejs#66508 Signed-off-by: Marten Richter <marten.richter@freenet.de>
40db343 to
69719cd
Compare
|
Ok, now, everything works according to the local tests. |
|
I do not understand the build failures. It complains about an unknown compiler option? Do I need to rebase? |
|
Looks like yes - it's complaining about That said, you'll then run into a separate issue, because that same V8 update has also independently broken the QUIC build 😆. Fix for that landing shortly, it's here: #66603 |
f49753c to
8a94755
Compare
|
I have moved (I have not rebased, as the fixes for building quic are not on main yet). |
The get writer method of QuicStream is mostly
generell enough to be usuable in other contexts.
This PR is an attempt to move the code out
of the QuicStream object to be usuable in other
parts of node.js.
Fixes #66508