-
-
Notifications
You must be signed in to change notification settings - Fork 38.9k
deps,lib,tools: remove jitless and lite modes #66459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const { spawnSync } = require('child_process'); | ||
|
|
||
| // Interpreter-only modes are overridden to preserve Node's WebAssembly | ||
| // requirement, including alternate spellings and the runtime flag API. | ||
| const wasm = ` | ||
| const assert = require('assert'); | ||
| assert.strictEqual(typeof WebAssembly, 'object'); | ||
| const bytes = Uint8Array.of(0, 97, 115, 109, 1, 0, 0, 0); | ||
| new WebAssembly.Instance(new WebAssembly.Module(bytes)); | ||
| `; | ||
|
|
||
| for (const flag of [ | ||
| '--jitless', '--lite-mode', '--lite_mode', '-jitless', '-lite_mode', | ||
| '--no-jitless', '--no-lite-mode', | ||
| ]) { | ||
| const result = spawnSync(process.execPath, [flag, '-e', wasm], { encoding: 'utf8' }); | ||
| assert.strictEqual(result.status, 0, result.stderr); | ||
| assert.strictEqual(result.signal, null); | ||
| assert.strictEqual(result.stderr, ''); | ||
|
|
||
| const runtime = spawnSync(process.execPath, ['-e', ` | ||
| require('v8').setFlagsFromString(${JSON.stringify(flag)}); | ||
| ${wasm} | ||
| // A new isolate must also retain WebAssembly after changing runtime flags. | ||
| new (require('worker_threads').Worker)(${JSON.stringify(wasm)}, { eval: true }); | ||
| `], { encoding: 'utf8' }); | ||
| assert.strictEqual(runtime.status, 0, runtime.stderr); | ||
| assert.strictEqual(runtime.stderr, ''); | ||
| } | ||
|
|
||
| // V8 boolean flags reject explicit values, even for overridden modes. | ||
| for (const flag of ['--jitless=true', '--lite_mode=true']) { | ||
| const result = spawnSync(process.execPath, [flag, '-e', wasm], { encoding: 'utf8' }); | ||
| assert.strictEqual(result.status, 9, result.stderr); | ||
| assert.strictEqual(result.signal, null); | ||
| assert.match(result.stderr, /illegal value for flag .* of type bool/); | ||
|
|
||
| // The runtime API reports invalid syntax without throwing, and Node must | ||
| // still override any flags V8 changed before reporting the error. | ||
| const runtime = spawnSync(process.execPath, ['-e', ` | ||
| require('v8').setFlagsFromString(${JSON.stringify(flag)}); | ||
| ${wasm} | ||
| new (require('worker_threads').Worker)(${JSON.stringify(wasm)}, { eval: true }); | ||
| `], { encoding: 'utf8' }); | ||
| assert.strictEqual(runtime.status, 0, runtime.stderr); | ||
| assert.strictEqual(runtime.signal, null); | ||
| assert.match(runtime.stderr, /illegal value for flag .* of type bool/); | ||
| } | ||
|
|
||
| // Node's overrides must not be treated as contradictory user-supplied flags. | ||
| for (const flag of ['--jitless', '--lite-mode']) { | ||
| const result = spawnSync(process.execPath, [ | ||
| '--abort-on-contradictory-flags', flag, '-e', wasm, | ||
| ], { encoding: 'utf8' }); | ||
| assert.strictEqual(result.status, 0, result.stderr); | ||
| assert.strictEqual(result.signal, null); | ||
| assert.strictEqual(result.stderr, ''); | ||
| } | ||
|
|
||
| const options = spawnSync(process.execPath, ['--v8-options'], { encoding: 'utf8' }); | ||
| assert.strictEqual(options.status, 0, options.stderr); | ||
| assert.match(options.stdout, /--jitless\b/); | ||
| assert.match(options.stdout, /--lite-mode\b/); | ||
|
|
||
| for (const flag of ['--jitless', '--lite-mode', '--lite_mode']) { | ||
| assert.strictEqual(process.allowedNodeEnvironmentFlags.has(flag), false); | ||
| if (!process.config.variables.node_without_node_options) { | ||
| const result = spawnSync(process.execPath, ['-e', ''], { | ||
| encoding: 'utf8', | ||
| env: { ...process.env, NODE_OPTIONS: flag }, | ||
| }); | ||
| assert.strictEqual(result.status, 9, result.stderr); | ||
| assert.match(result.stderr, /is not allowed in NODE_OPTIONS/); | ||
| } | ||
| } | ||
|
|
||
| // Workers must inherit a runtime with working WebAssembly as well. | ||
| const { Worker } = require('worker_threads'); | ||
| const worker = new Worker(` | ||
| const { parentPort } = require('worker_threads'); | ||
| const bytes = Uint8Array.of(0, 97, 115, 109, 1, 0, 0, 0); | ||
| new WebAssembly.Instance(new WebAssembly.Module(bytes)); | ||
| parentPort.postMessage(typeof WebAssembly); | ||
| `, { eval: true }); | ||
| worker.on('message', common.mustCall((value) => assert.strictEqual(value, 'object'))); | ||
| worker.on('exit', common.mustCall((code) => assert.strictEqual(code, 0))); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--allow-overwriting-for-next-flaghas been removed by V8 which now only allows ignoring the contradiction https://chromium-review.googlesource.com/c/v8/v8/+/7775553Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a revert #66516 to unblock the V8 upgrade. IMO to reland this PR, it's better to add some support in the upstream for the override first, otherwise this just leaves no way of opting-into jitless etc. even if the users do it at their own risk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoyeeChung Thanks, I didn't know about it.
We have two choices here:
1 - As in the original PR we remove support for jitless. Unlike the original PR I would throw if the user tries to enable it rather than overwrite it.
2 - we let them to, but whenever the user tries to access WebAssemly we also throw an error and exit. But this also means that some part of Node might be totally unaccessible in the future.
To clarify, when I introduce Milo as replacement of llhttp, the entire http1 will be affected. Fetch is already like that today. That's why I went for the hard route.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joyeecheung I just sent #66524, which should eliminate the need for the revert. PTAL.