Skip to content

build: update configure.py and common.gypi for z/OS - #66449

Closed
gabylb wants to merge 3 commits into
nodejs:mainfrom
gabylb:zos-build
Closed

build: update configure.py and common.gypi for z/OS#66449
gabylb wants to merge 3 commits into
nodejs:mainfrom
gabylb:zos-build

Conversation

@gabylb

@gabylb gabylb commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Please see each commit's message for description. All changes here affect z/OS only.

gabylb added 2 commits October 1, 2026 16:52
@gabylb
build: update configure.py for z/OS
1167f85 
- Compile gen/icudt*.c instead of .S.
- Check required environment variables and configure.py args are set.
- Remove no-longer needed variables.
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@gabylb
build: update common.gypi for z/OS
40e320c 
- Don't use icu data file on z/OS; use libnode's bundled ICU data.
- Include required defines, cflags, ldflags, and remove unsupported ones,
  following switch to clang compiler.
- Remove _ALL_SOURCE, as _POSIX_C_SOURCE and _POSIX_SOURCE already
  enable all required library functions (in deps/uv/CMakeLists.txt, only
  _OPEN_SYS is required to enable setgroups (in grp.h) instead of
  _ALL_SOURCE); also remove dup _OPEN_SYS_SOCK_IPV6.
- Add -D_EXT to defines (for setenv, and vsam.js' `__KEY_*` macros).
- Add _POSIX_C_SOURCE=200809L to enable at least `utimensat`.
- Add clang option -mzos-target=zosv2r5 also to ldflags, otherwise the
  default LE dataset is used that may not be for the current target.
- Add -m64 to ldflags, otherwise ld passes `AMODE=31,LIST,..` to
  the binder, causing unresolved symbols if the non-64 suffixed version
  of the compiler was used (e.g. ibm-clang instead of ibm-clang64).
- Add zoslib/include-wrappers/c++ in include_dirs for custom aligned new
  and delete operators.
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 1, 2026
@gabylb

gabylb commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

For the lint error stating to use dict.get() instead, please note that in this case we want configure.py to terminate if the environment variable isn't set.

@richardlau

richardlau commented Oct 2, 2026

Copy link
Copy Markdown
Member

@gabylb The common.gypi changes LGTM. We will need to address the linter failure before this can land, either by modifying the code or somehow suppressing the warning just for the occurrence in question.

For the lint error stating to use dict.get() instead, please note that in this case we want configure.py to terminate if the environment variable isn't set.

Could the code not raise an Exception if dict.get() returns the default None?

@gabylb
build: use dict.get() in configure.py
e3b0b2d 
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78138/

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 3, 2026
@richardlau richardlau removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 3, 2026
@richardlau richardlau self-assigned this Oct 3, 2026
@richardlau

richardlau commented Oct 3, 2026

Copy link
Copy Markdown
Member

I'll land this manually on Monday (assuming no requests for changes), squashing the two commits affecting configure.py.

richardlau pushed a commit that referenced this pull request Oct 5, 2026
@gabylb @richardlau
build: update configure.py for z/OS
6c116e8 
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
PR-URL: #66449
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau pushed a commit that referenced this pull request Oct 5, 2026
@gabylb @richardlau
build: update common.gypi for z/OS
c413d1a 
- Don't use icu data file on z/OS; use libnode's bundled ICU data.
- Include required defines, cflags, ldflags, and remove unsupported
  ones, following switch to clang compiler.
- Remove _ALL_SOURCE, as _POSIX_C_SOURCE and _POSIX_SOURCE already
  enable all required library functions (in deps/uv/CMakeLists.txt, only
  _OPEN_SYS is required to enable setgroups (in grp.h) instead of
  _ALL_SOURCE); also remove dup _OPEN_SYS_SOCK_IPV6.
- Add -D_EXT to defines (for setenv, and vsam.js' `__KEY_*` macros).
- Add _POSIX_C_SOURCE=200809L to enable at least `utimensat`.
- Add clang option -mzos-target=zosv2r5 also to ldflags, otherwise the
  default LE dataset is used that may not be for the current target.
- Add -m64 to ldflags, otherwise ld passes `AMODE=31,LIST,..` to
  the binder, causing unresolved symbols if the non-64 suffixed version
  of the compiler was used (e.g. ibm-clang instead of ibm-clang64).
- Add zoslib/include-wrappers/c++ in include_dirs for custom aligned new
  and delete operators.

PR-URL: #66449
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Signed-off-by: Richard Lau <richard.lau@ibm.com>
@richardlau

richardlau commented Oct 5, 2026

Copy link
Copy Markdown
Member

Landed in bbd566d...c413d1a.

@richardlau richardlau closed this Oct 5, 2026
@richardlau richardlau added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 5, 2026
aduh95 pushed a commit that referenced this pull request Oct 5, 2026
@gabylb @aduh95
build: update configure.py for z/OS
0002037 
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
PR-URL: #66449
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Oct 5, 2026
@gabylb @aduh95
build: update common.gypi for z/OS
9f1db46 
- Don't use icu data file on z/OS; use libnode's bundled ICU data.
- Include required defines, cflags, ldflags, and remove unsupported
  ones, following switch to clang compiler.
- Remove _ALL_SOURCE, as _POSIX_C_SOURCE and _POSIX_SOURCE already
  enable all required library functions (in deps/uv/CMakeLists.txt, only
  _OPEN_SYS is required to enable setgroups (in grp.h) instead of
  _ALL_SOURCE); also remove dup _OPEN_SYS_SOCK_IPV6.
- Add -D_EXT to defines (for setenv, and vsam.js' `__KEY_*` macros).
- Add _POSIX_C_SOURCE=200809L to enable at least `utimensat`.
- Add clang option -mzos-target=zosv2r5 also to ldflags, otherwise the
  default LE dataset is used that may not be for the current target.
- Add -m64 to ldflags, otherwise ld passes `AMODE=31,LIST,..` to
  the binder, causing unresolved symbols if the non-64 suffixed version
  of the compiler was used (e.g. ibm-clang instead of ibm-clang64).
- Add zoslib/include-wrappers/c++ in include_dirs for custom aligned new
  and delete operators.

PR-URL: #66449
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Signed-off-by: Richard Lau <richard.lau@ibm.com>
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Assignees

@richardlau richardlau

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabylb @nodejs-github-bot @richardlau @cjihrig @panva