Conversation
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Fix incorrect negative index results for large buffers. Add tests for number, Buffer and string searches beyond 2 GiB. Fixes: nodejs#66294 Signed-off-by: dansatch <dansatch98@gmail.com>
Dansatch
force-pushed
the
fix-buffer-indexof-2gib
branch
from
September 26, 2026 18:00
d1a0f65 to
04a1fd7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66325 +/- ##
==========================================
- Coverage 90.37% 90.37% -0.01%
==========================================
Files 790 790
Lines 274514 274514
Branches 52572 52570 -2
==========================================
- Hits 248102 248089 -13
- Misses 16889 16921 +32
+ Partials 9523 9504 -19
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66294.
Buffer.prototype.indexOf()returned a negative position when a match occurred beyond 2 GiB because the result was converted to a signed 32-bit integer.This change returns the position as a JavaScript number and adds regression tests for number, Buffer, and string searches.