Conversation
Remove entries for test-performance-function and test-report-fatal-error. Both tests were renamed, so their original names no longer match tests. Refs: nodejs#54803 Refs: nodejs#43457 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
The entries added for Linux arm64 debug failures use arch==arm, so they do not match that configuration. Since 9ea6182, the shared SEA guard also correctly skips executable tests on Linux debug builds. Remove the stale entries. The tests without that guard only validate SEA configuration errors. Refs: nodejs#63749 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
The test could finish its workload without recording a workload frame. 0ab4a1c increased the non-Windows workload from fib(30) to fib(40), and 92e6342 moved Profiler.setSamplingInterval before Profiler.start so the requested interval takes effect. Remove the flaky expectation left over from before those fixes. Refs: nodejs#27611 Refs: nodejs#32168 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
Background compilation could deadlock at process exit: DrainTasks waited for the compiler task while that task waited for main-thread garbage collection. Since 5fb879c, only user-blocking tasks count toward that wait, excluding ordinary background compilation. Remove the old flaky expectations for test-http2-large-file and test-fs-read-stream-concurrent-reads. Refs: nodejs#47409 Refs: nodejs#51862 Refs: nodejs#54918 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
Disconnecting the inspector can race with its final notification write. If EOF resets the socket first, the write used to dereference a null TCP handle. 8a84e6b added guards for writes after disconnect. Removing those guards reproduces the loader test's SIGSEGV under a scheduling-delay probe; the normal binary passes the same probe. Remove the flaky expectations left over from before that fix. Refs: nodejs#54346 Refs: nodejs#34833 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
panva
added
the
commit-queue-rebase
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
panva
added
the
flaky-test
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66319 +/- ##
==========================================
- Coverage 90.38% 90.37% -0.01%
==========================================
Files 790 790
Lines 274497 274514 +17
Branches 52557 52566 +9
==========================================
Hits 248100 248100
- Misses 16879 16884 +5
- Partials 9518 9530 +12 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove flaky expectations that no longer apply:
test-performance-functionandtest-report-fatal-errorwere renamed, leaving entries that no longer match any tests.arch==armdespite targeting arm64 failures. The shared SEA guard now skips Linux debug executable tests.test-cpu-prof-dir-workerpredates fixes to its workload size and profiler sampling interval.test-http2-large-fileandtest-fs-read-stream-concurrent-readspredate the fix for background compilation deadlocks at process exit.test-esm-loader-hooks-inspect-waitpredates the inspector fix for writes after disconnect.