Conversation
panva
added
flaky-test
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Async hook activation can be deferred when the inspector command arrives during a V8 interrupt. Schedule timeout creation with setImmediate so the event loop finishes enabling the hooks before recording its async stack. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Use a dedicated fixture with a pending promise and assertion plan instead of competing assertion timers. Keep both timeout failure assertions and clear the keepalive interval after the tests finish. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
force-pushed
the
deflake-inspector-runner-run
branch
from
September 24, 2026 07:43
a373d46 to
b7526ad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66255 +/- ##
==========================================
+ Coverage 90.28% 90.30% +0.01%
==========================================
Files 789 789
Lines 272878 272878
Branches 52097 52105 +8
==========================================
+ Hits 246360 246409 +49
+ Misses 16975 16917 -58
- Partials 9543 9552 +9 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
avivkeller
approved these changes
Sep 25, 2026
panva
added
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/nodejs/reliability/blob/main/reports/2026-09-24.md
test-inspector-async-hook-setup-at-signal, defer timeout creation withsetImmediateso async-hook activation requested during a V8 interrupt can finish first.test-runner-run, use a dedicated fixture with a pending promise and assertion plan, removing competing assertion timers while preserving both timeout-failure checks.