Conversation
Official linux-x64 installs copied generated OpenSSL headers for
every OS/arch (~64 MB). A full install now keeps the build arch
plus linux-elf, which dispatcher headers include from #else.
Unknown hosts keep the full set so a guessed Linux mapping cannot
drop headers the dispatcher actually uses. OpenBSD maps to BSD-*
like the dispatcher. Solaris is detected with startswith('sunos')
because Python reports sunos5. macOS keeps both darwin64 arches
because the official .pkg is a universal binary. The headers-only
tarball is unchanged so node-gyp can still target any platform.
On node-v26.9.0-linux-x64 this cuts the extracted install from
229 MB to about 171 MB (about 25%).
Assisted-by: a closed-source coding agent
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot
added
build
The JS linter forbids a string literal as the third argument of assert.deepStrictEqual(). Assisted-by: a closed-source coding agent Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66176 +/- ##
==========================================
+ Coverage 90.27% 90.28% +0.01%
==========================================
Files 790 790
Lines 271651 272043 +392
Branches 51842 51939 +97
==========================================
+ Hits 245228 245625 +397
- Misses 16928 16930 +2
+ Partials 9495 9488 -7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Official Node.js linux-x64 installs currently copy generated OpenSSL headers for every OS/arch into
include/node/openssl/archs(~64 MB). Native addons only need the headers that match the installednodebinary, plus the dispatcher#elsefallback (linux-elf).A full install now keeps the build arch plus
linux-elf. The headers-only tarball (make tar-headers) is unchanged so node-gyp can still target any platform.Unknown hosts keep the full set (no guessed Linux mapping). OpenBSD maps to
BSD-*. Solaris is detected withstartswith('sunos')because Python reportssunos5. macOS keeps bothdarwin64-arm64-ccanddarwin64-x86_64-ccbecause the official.pkgis a universal binary.--shared-opensslbuilds still do not install bundled arch headers; the new test skips that configuration.This change was implemented with assistance from a closed-source coding agent. I verified
tools/install.py, the arch mapping againstdeps/openssl/openssl_asm.gypi, andtest-install-openssl-headers.js.Size
Measured against
node-v26.9.0-linux-x64:The compressed
.tar.xzdownload is almost unchanged because those headers compress extremely well; the win is disk / Docker / nvm extract size.Tests
test-install-openssl-headers.js.