sqlite: rename DatabaseSync to Database by araujogui · Pull Request #65988 · nodejs/node

araujogui · 2026-09-11T17:12:22Z

Rename the DatabaseSync class to Database and StatementSync to Statement.
Keep old names as aliases with doc-only deprecations.

See #57445 (comment)

nodejs-github-bot · 2026-09-11T17:12:28Z

Review requested:

@nodejs/performance
@nodejs/security-wg
@nodejs/sqlite
@nodejs/tsc

cjihrig · 2026-09-11T17:23:15Z

I didn't review the code fully, but does this leave an alias behind? If not, this will break every single current user.

araujogui · 2026-09-11T17:27:55Z

I didn't review the code fully, but does this leave an alias behind? If not, this will break every single current user.

No, it doesn't. I will add it later

codecov · 2026-09-11T20:45:02Z

Codecov Report

❌ Patch coverage is 88.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.29%. Comparing base (3a15c5d) to head (2b3ccb5).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.64%	16 Missing ⚠️
src/node_sqlite.h	38.46%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #65988    +/-   ##
========================================
  Coverage   90.29%   90.29%            
========================================
  Files         790      789     -1     
  Lines      272531   272879   +348     
  Branches    52037    52111    +74     
========================================
+ Hits       246070   246405   +335     
- Misses      16915    16928    +13     
  Partials     9546     9546

Files with missing lines	Coverage Δ
lib/sqlite.js	`100.00% <100.00%> (ø)`
src/node_sqlite.h	`87.27% <38.46%> (ø)`
src/node_sqlite.cc	`81.98% <90.64%> (-0.08%)`	⬇️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

lgtm

github-actions · 2026-09-13T19:39:17Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @mcollina.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

gurgunday

lgtm

araujogui · 2026-09-14T16:40:47Z

@nodejs/sqlite should we rename StatementSync to Statement too?

geeksilva97 · 2026-09-14T17:29:20Z

@nodejs/sqlite should we rename StatementSync to Statement too?

I'd say so. It was in my plan in our first attempt.

araujogui · 2026-09-22T13:07:33Z

@RafaelGSS do you still have request changes?

RafaelGSS

The doc-only deprecation and aliases address my concern

Existing usage continues to work without a runtime warning, so semver-minor makes sense to me. LGTM.

nodejs-github-bot · 2026-09-23T10:55:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77785/

Rename the DatabaseSync class to Database, and the internal DatabaseSyncLimits helper to DatabaseLimits to match. Assisted-by: Claude Code Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

DatabaseSync is kept as an alias of Database, wrapped with a DEP0210 runtime deprecation warning, so existing code using the pre-rename name keeps working. Assisted-by: Claude Code Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

lib/sqlite.js used object-spread (`...sqlite`) to re-export the internal binding, which crashed tools/doc's api-links generator: it walks module.exports's ObjectExpression properties expecting a `value` on each one, and a SpreadElement has no such property (TypeError: Cannot read properties of undefined (reading 'type')). This broke the "Build from tarball" CI job. Destructure the binding's exports into bare identifiers instead, matching the pattern already used in lib/crypto.js for its deprecated Hash/Hmac exports. Also fill in the DEP0210 changes entry's pr-url, now that the pull request exists. Assisted-by: Claude Code Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

New deprecations start out Documentation-only and only gain a runtime warning in a later release, same as DEP0179/DEP0181 did for crypto.Hash/Hmac. Drop the util.deprecate() wrapper for now: export DatabaseSync as a plain alias of Database again (same function identity, no warning), and mark DEP0210 as Documentation-only in the docs. Assisted-by: Claude Code Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

Copilot AI lite review requested due to automatic review settings September 11, 2026 17:12

This comment was marked as low quality.

Sign in to view

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 11, 2026

araujogui force-pushed the sqlite-rename-database-class branch from d90b1f9 to b52ec3e Compare September 11, 2026 17:20

araujogui commented Sep 11, 2026

View reviewed changes

Comment thread lib/sqlite.js Outdated

mcollina approved these changes Sep 13, 2026

View reviewed changes

mcollina added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 13, 2026

mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 13, 2026

gurgunday approved these changes Sep 13, 2026

View reviewed changes

RafaelGSS added the deprecations Issues and PRs related to deprecations. label Sep 14, 2026

RafaelGSS requested changes Sep 14, 2026

View reviewed changes

Comment thread doc/api/deprecations.md

jasnell approved these changes Sep 14, 2026

View reviewed changes

araujogui force-pushed the sqlite-rename-database-class branch from 7debaa5 to 3fa9279 Compare September 14, 2026 18:17

araujogui force-pushed the sqlite-rename-database-class branch from 3fa9279 to 8fec2eb Compare September 22, 2026 13:06

ronag approved these changes Sep 22, 2026

View reviewed changes

trivikr requested a review from RafaelGSS September 22, 2026 17:40

RafaelGSS approved these changes Sep 22, 2026

View reviewed changes

araujogui added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2026

anonrig approved these changes Sep 23, 2026

View reviewed changes

gurgunday approved these changes Sep 23, 2026

View reviewed changes

TrevorBurnham mentioned this pull request Sep 23, 2026

sqlite: add batched async Database API #62015

Open

9 tasks

araujogui added 6 commits September 23, 2026 15:57

sqlite: rename DatabaseSync to Database

dd0c3b7

Rename the DatabaseSync class to Database, and the internal DatabaseSyncLimits helper to DatabaseLimits to match. Assisted-by: Claude Code Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

sqlite: rename StatementSync to Statement

8b673e8

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

sqlite: remove duplicate Database prototype methods

2b3ccb5

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui force-pushed the sqlite-rename-database-class branch from 8fec2eb to 2b3ccb5 Compare September 23, 2026 18:58

ronag approved these changes Sep 24, 2026

View reviewed changes

Uh oh!

Conversation

araujogui commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 11, 2026

Uh oh!

This comment was marked as low quality.

Uh oh!

cjihrig commented Sep 11, 2026

Uh oh!

araujogui commented Sep 11, 2026

Uh oh!

Uh oh!

codecov Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 13, 2026

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

araujogui commented Sep 14, 2026

Uh oh!

geeksilva97 commented Sep 14, 2026

Uh oh!

araujogui commented Sep 22, 2026

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

araujogui commented Sep 11, 2026 •

edited

Loading

codecov Bot commented Sep 11, 2026 •

edited

Loading