You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we don't currently have any unit tests in this repo we first need to get the basic structure in place for how we want to arrange the tests.
I'm keen that we have some consistency with the other repos in the node-red org. On that basis, I'd suggest:
All tests should be in a top-level test folder - with a folder structure that mirrors the src structure.
That means the test you've added should be in test/lib/rules/no-duplicate-html-in-url.spec.js
We use should rather than chai elsewhere. I'm not sure why/how chai came to be listed as an existing dev dependency, it certainly isn't used anywhere I can see in the repo. It may be a legacy dependency from the very early development of the linter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to add a very simple unit test to the nrlint rules section of NR Lint.
I have not added it to Dev,
Proposed changes
This is my first attempt at creating a simple unit test for NR Lint rules.
Checklist