Skip to content

settings: add an "force en translation" toggle on top#2985

Open
jinliu wants to merge 1 commit into
noctalia-dev:mainfrom
jinliu:feature/debug-force-en
Open

settings: add an "force en translation" toggle on top#2985
jinliu wants to merge 1 commit into
noctalia-dev:mainfrom
jinliu:feature/debug-force-en

Conversation

@jinliu

@jinliu jinliu commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This should be convenient for translators when proofreading translations.
When you find something in doubt, just turn on this toggle to check the
original English text, without needing to go to the translation website
and search.

To enable it, set the environment variable NOCTALIA_TRANSLATOR=1 before
launching Noctalia. E.g.:

NOCTALIA_TRANSLATOR=1 noctalia

Copilot AI review requested due to automatic review settings June 11, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a debug-only UI control in the Settings filter row to force the application language to English for easier localization/UX debugging.

Changes:

  • Introduces a #ifndef NDEBUG “en” label and toggle in the settings filter row.
  • Tracks toggle state via a new debug-only m_forceEnTranslation member.
  • Switches i18n::Service language to "en" when enabled and back to configured language when disabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/shell/settings/settings_window_scene.cpp Adds debug-only label + toggle that switches the runtime language via i18n::Service.
src/shell/settings/settings_window.h Adds debug-only member to track the “force English” toggle state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/shell/settings/settings_window_scene.cpp Outdated
Comment thread src/shell/settings/settings_window_scene.cpp Outdated
@ItsLemmy

Copy link
Copy Markdown
Collaborator

I like the idea, but I think it could be better. Right now this assumes translator run the debug build, which most probably don't as they are not developers.

Maybe via a ENV var would be better.

@jinliu

jinliu commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Maybe via a ENV var would be better.

Good idea. Will do.

This should be convenient for translators when proofreading translations.
When you find something in doubt, just turn on this toggle to check the
original English text, without needing to go to the translation website
and search.

To enable it, set the environment variable NOCTALIA_TRANSLATOR=1 before
launching Noctalia. E.g.:

    NOCTALIA_TRANSLATOR=1 noctalia
@jinliu jinliu force-pushed the feature/debug-force-en branch from ad47a0b to bdc28a1 Compare June 12, 2026 02:35
@jinliu jinliu changed the title settings: add an "force en translation" toggle on top in debug mode settings: add an "force en translation" toggle on top Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants