settings: add an "force en translation" toggle on top#2985
Open
jinliu wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a debug-only UI control in the Settings filter row to force the application language to English for easier localization/UX debugging.
Changes:
- Introduces a
#ifndef NDEBUG“en” label and toggle in the settings filter row. - Tracks toggle state via a new debug-only
m_forceEnTranslationmember. - Switches
i18n::Servicelanguage to"en"when enabled and back to configured language when disabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/shell/settings/settings_window_scene.cpp | Adds debug-only label + toggle that switches the runtime language via i18n::Service. |
| src/shell/settings/settings_window.h | Adds debug-only member to track the “force English” toggle state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
I like the idea, but I think it could be better. Right now this assumes translator run the debug build, which most probably don't as they are not developers. Maybe via a ENV var would be better. |
Contributor
Author
Good idea. Will do. |
This should be convenient for translators when proofreading translations.
When you find something in doubt, just turn on this toggle to check the
original English text, without needing to go to the translation website
and search.
To enable it, set the environment variable NOCTALIA_TRANSLATOR=1 before
launching Noctalia. E.g.:
NOCTALIA_TRANSLATOR=1 noctalia
ad47a0b to
bdc28a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be convenient for translators when proofreading translations.
When you find something in doubt, just turn on this toggle to check the
original English text, without needing to go to the translation website
and search.
To enable it, set the environment variable NOCTALIA_TRANSLATOR=1 before
launching Noctalia. E.g.: