bluetooth: try getting battery percentage from upower if missing from bluez#2967
Open
jinliu wants to merge 1 commit into
Open
bluetooth: try getting battery percentage from upower if missing from bluez#2967jinliu wants to merge 1 commit into
jinliu wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a UPower-based fallback to display Bluetooth device battery percentages when BlueZ doesn’t report them.
Changes:
- Pass
UPowerService*into Control Center’sBluetoothTaband the barBluetoothWidget. - Query UPower by Bluetooth address to show battery % in the device list rows and widget tooltip.
- Normalize Bluetooth addresses via
StringUtils::toLower(...)before querying UPower.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shell/control_center/control_center_panel.cpp | Wires UPowerService* into BluetoothTab construction. |
| src/shell/control_center/bluetooth_tab.h | Extends BluetoothTab API to accept/store UPowerService*. |
| src/shell/control_center/bluetooth_tab.cpp | Uses UPower as fallback battery source for device rows. |
| src/shell/bar/widgets/bluetooth_widget.h | Extends BluetoothWidget API to accept/store UPowerService*. |
| src/shell/bar/widgets/bluetooth_widget.cpp | Uses UPower as fallback battery source in tooltip. |
| src/shell/bar/widget_factory.cpp | Passes m_upower into BluetoothWidget creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… bluez Bluetooth widget / tab will now also query UPowerService for battery percentage if BluetoothService doesn't provide it. An example of this is the Playstation 5 controller.
jinliu
force-pushed
the
feature/bluetooth-batt-upower
branch
from
1917b26 to
29d15fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bluetooth widget / tab will now also query UPowerService for battery percentage if BluetoothService doesn't provide it.
An example of this is the Playstation 5 controller.