Remove serialization for derived key handles, remove keySpec property#40
Remove serialization for derived key handles, remove keySpec property#40jkoenig134 merged 7 commits into
Conversation
Removed `KeySpec` from BaseKeyHandle as there is currently no use in sync context.
Refactored *Derived variant of key handles to not use BaseKeyHandle anymore, but rather a DerivedBaseKeyHandle that does not support serialization. The need stems from derived key handles being ephemeral. If they are being dropped, they do not exist anymore. Hence deserializing ephemeral key handles does not make sense and will result in an error.
|
@WyvernIXTL Please note, that we switched to GitHub Releases in this repo. Since we now use labels to generate the release notes, we no longer prefix the PR titles. |
WyvernIXTL
changed the title
|
@Milena-Czierlinski Hi, sorry, I overlooked that. I cannot label this PR or assign anyone to review this PR for that matter. |
Mhh that is strange. Would you like me to assign a reviewer for you for now? @WyvernIXTL |
|
@Milena-Czierlinski Yes, please. |
|
And whom...? 😂 |
|
@Milena-Czierlinski ┐(‘～`;)┌ |
|
@Milena-Czierlinski I don't think I'm the most qualified person to do that review. Could you choose someone who worked on ts-crypto before or someone who is experienced with developing the runtime in general? |
|
In the failing pipeline it says |
|
Hm, the quick solution for that would be to finally switch to a non forked version of this repo as discussed with @ngussek and @WyvernIXTL. But we can check if it's possible to support this pipeline for forks later. |
jkoenig134
merged commit 45df57f
into
nmshd:feature/cal-integration
5 participants
Readiness checklist
Description
keySpecproperty ofBaseKeyHandleand derivatives, due to the property neither being used, norts-servalbeing able to skip certain verifications (instanceofwith@validate()).Derivedvariants of of key handle not be able to serialize. A derived key handle is ephemeral. Deserializing such key handle is only possible if a provider stores an ephemeral key handle, or if the serialized representation stores the secret key. Neither is in the spirit of a key handle.from*methods of derivatives ofBaseKeyHandleinferringBaseKeyHandleas return type.