Enable -isystem for third-party headers on Ubuntu#13
Open
billdenney wants to merge 1 commit into
Open
Conversation
workaround.R only selected -isystem (vs plain -I) for third-party headers (BH, RcppEigen, Rcpp, StanHeaders) on Pop!_OS, falling back to -I everywhere else. On Ubuntu this exposed thousands of -Wignored-attributes and -Wdeprecated-declarations warnings from RcppEigen and boost on every build, burying any real diagnostic from rxode2ll's own code. Sibling package rxode2 already selects -isystem for both Pop!_OS and Ubuntu; match that here so third-party headers are treated as system headers and their warnings are suppressed (~9300 -> 0 warnings on Ubuntu, including GitHub Actions runners). No effect on other platforms. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
inst/tools/workaround.Ronly selected-isystem(vs plain-I) for third-party headers (BH, RcppEigen, Rcpp, StanHeaders) on Pop!_OS, falling back to-Ieverywhere else. On Ubuntu this exposed ~9,300-Wignored-attributes/-Wdeprecated-declarationswarnings from RcppEigen and boost on every build, burying any real diagnostic from rxode2ll's own code.Why
None of these warnings come from rxode2ll's own source — they're all third-party Eigen/boost. Sibling package rxode2 already selects
-isystemfor both Pop!_OS and Ubuntu; this just adds the missingUbuntubranch so the two stay consistent and third-party headers are correctly treated as system headers.Impact
-I, as before).🤖 Generated with Claude Code